[GitHub] [buildstream] juergbi commented on a change in pull request #1566: workspace.py: Remove assumption on specific kinds to testing multiple

[GitBox <gi...@apache.org>]

juergbi commented on a change in pull request #1566:
URL: https://github.com/apache/buildstream/pull/1566#discussion_r785331196



##########
File path: tests/frontend/workspace.py
##########
@@ -175,20 +187,13 @@ def test_open_bzr_customize(cli, tmpdir, datafiles):
 
 @pytest.mark.datafiles(DATA_DIR)
 def test_open_multi(cli, tmpdir, datafiles):
-
     workspace_object = WorkspaceCreator(cli, tmpdir, datafiles)
     workspaces = workspace_object.open_workspaces(repo_kinds)
 
     for (elname, workspace), kind in zip(workspaces, repo_kinds):
         assert kind in elname
         workspace_lsdir = os.listdir(workspace)
-        if kind == "git":
-            assert ".git" in workspace_lsdir

Review comment:
       Do we lose the check that a workspace on a git source has a `.git` directory? Or is such a check irrelevant or redundant (it might make sense to check this in a plugin-specific test)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org