You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/02/23 02:50:51 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1263: [CELEBORN-329] Add rpc address to exception message when failed to se…
zhongqiangczq opened a new pull request, #1263:
URL: https://github.com/apache/incubator-celeborn/pull/1263
…ndrpc
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1263: [CELEBORN-329][Flink] Add rpc address to exception message when failed to se…
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1263:
URL: https://github.com/apache/incubator-celeborn/pull/1263#discussion_r1115541798
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -228,7 +228,7 @@ public void onFailure(Throwable e) {
try {
return result.get(timeoutMs, TimeUnit.MILLISECONDS);
} catch (Exception e) {
- throw new IOException("Exception in sendRpcSync", e);
+ throw new IOException("Exception in sendRpcSync to:" + this.getSocketAddress(), e);
Review Comment:
This is used for flink write process. We wanted to know which worker client failed to push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1263: [CELEBORN-329][Flink] Add rpc address to exception message when failed to se…
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1263:
URL: https://github.com/apache/incubator-celeborn/pull/1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1263: [CELEBORN-329] Add rpc address to exception message when failed to se…
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1263:
URL: https://github.com/apache/incubator-celeborn/pull/1263#discussion_r1115199152
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -228,7 +228,7 @@ public void onFailure(Throwable e) {
try {
return result.get(timeoutMs, TimeUnit.MILLISECONDS);
} catch (Exception e) {
- throw new IOException("Exception in sendRpcSync", e);
+ throw new IOException("Exception in sendRpcSync to:" + this.getSocketAddress(), e);
Review Comment:
Here only called when PartitionReader fetch open chunk, if you want to do this, maybe we should also handle `askSync`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1263: [CELEBORN-329] Add rpc address to exception message when failed to se…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1263:
URL: https://github.com/apache/incubator-celeborn/pull/1263#issuecomment-1441157007
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1263?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1263](https://codecov.io/gh/apache/incubator-celeborn/pull/1263?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55ba3e8) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/1132cc25ab1717b67c3fd53b8f0632b3b7d96f71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1132cc2) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1263 +/- ##
============================================
+ Coverage 27.10% 27.12% +0.02%
- Complexity 811 813 +2
============================================
Files 215 215
Lines 18360 18360
Branches 1999 1999
============================================
+ Hits 4975 4978 +3
+ Misses 13059 13057 -2
+ Partials 326 325 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eleborn/common/network/client/TransportClient.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0Q2xpZW50LmphdmE=) | `32.31% <0.00%> (ø)` | |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `77.93% <0.00%> (+1.36%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org