[GitHub] [tvm] jcf94 commented on a change in pull request #8785: [FIX] Bug fix for batch_matmul parameters mismatch

[GitBox <gi...@apache.org>]

jcf94 commented on a change in pull request #8785:
URL: https://github.com/apache/tvm/pull/8785#discussion_r691710645



##########
File path: python/tvm/topi/cuda/batch_matmul.py
##########
@@ -258,11 +260,20 @@ def batch_matmul_int8(cfg, x, y, out_shape=None, out_dtype=None):
     out_dtype : Optional[str]
         Specifies the output data type for mixed precision batch matmul.
 
+    transpose_a : Optional[bool] = False
+        Whether the first tensor is in transposed format.
+
+    transpose_b : Optional[bool] = True
+        Whether the second tensor is in transposed format.
+
     Returns
     -------
     output : tvm.te.Tensor
         3-D with shape [batch, M, N]
     """
+    del out_shape

Review comment:
       Yeah, just some linting tools (like ctypes) may throw an error on unused parameters. Since we've not enabled the ctypes check here, leave this here will not affect anything.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org