You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/07 18:58:00 UTC
[jira] [Commented] (THRIFT-4679) Duplicate declaration of
InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713192#comment-16713192 ]
ASF GitHub Bot commented on THRIFT-4679:
----------------------------------------
griffinmichl opened a new pull request #1642: THRIFT-4679: Remove unused variable declaration
URL: https://github.com/apache/thrift/pull/1642
Changes are backwards compatible (as this line never did anything)
https://issues.apache.org/jira/browse/THRIFT-4679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
> -------------------------------------------------------------------------------------------
>
> Key: THRIFT-4679
> URL: https://issues.apache.org/jira/browse/THRIFT-4679
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
> Affects Versions: 0.11.0
> Reporter: Griffin Michl
> Priority: Minor
> Labels: easyfix
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> InputBufferUnderrunError is unnecessarily declared twice in `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to break when they attempt to compile code that uses the node thrift library. We should remove the first declaration, as it does not do anything.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)