You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Jarek Cecho <ja...@apache.org> on 2013/10/16 20:00:29 UTC
Review Request 14678: PIG-3519 Remove dependency on uber avro-tools jar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14678/
-----------------------------------------------------------
Review request for pig.
Bugs: PIG-3519
https://issues.apache.org/jira/browse/PIG-3519
Repository: pig-git
Description
-------
I've changed the dependency on avro-tools to request the "no dependency" classifier and added missing dependencies such as trevni-core (test jar) or trevni-avro (test jar).
Diffs
-----
ivy.xml b8a9bb9
ivy/libraries.properties 464ff11
Diff: https://reviews.apache.org/r/14678/diff/
Testing
-------
TestAvroStorage seems to be the only user of this dependency at it seems to be working:
ant clean test -Dtestcase=TestAvroStorage
Thanks,
Jarek Cecho
Re: Review Request 14678: PIG-3519 Remove dependency on uber avro-tools jar
Posted by Jarek Cecho <ja...@apache.org>.
> On Oct. 16, 2013, 6:29 p.m., Cheolsoo Park wrote:
> > Thank you Jarcec for fixing this. I included this.
> >
> > I will commit it trunk.
Thank you for the quick review Cheolsoo, appreciated!
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14678/#review27077
-----------------------------------------------------------
On Oct. 16, 2013, 6 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14678/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 6 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-3519
> https://issues.apache.org/jira/browse/PIG-3519
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> I've changed the dependency on avro-tools to request the "no dependency" classifier and added missing dependencies such as trevni-core (test jar) or trevni-avro (test jar).
>
>
> Diffs
> -----
>
> ivy.xml b8a9bb9
> ivy/libraries.properties 464ff11
>
> Diff: https://reviews.apache.org/r/14678/diff/
>
>
> Testing
> -------
>
> TestAvroStorage seems to be the only user of this dependency at it seems to be working:
>
> ant clean test -Dtestcase=TestAvroStorage
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 14678: PIG-3519 Remove dependency on uber avro-tools jar
Posted by Cheolsoo Park <pi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14678/#review27077
-----------------------------------------------------------
Ship it!
Thank you Jarcec for fixing this. I included this.
I will commit it trunk.
- Cheolsoo Park
On Oct. 16, 2013, 6 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14678/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 6 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-3519
> https://issues.apache.org/jira/browse/PIG-3519
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> I've changed the dependency on avro-tools to request the "no dependency" classifier and added missing dependencies such as trevni-core (test jar) or trevni-avro (test jar).
>
>
> Diffs
> -----
>
> ivy.xml b8a9bb9
> ivy/libraries.properties 464ff11
>
> Diff: https://reviews.apache.org/r/14678/diff/
>
>
> Testing
> -------
>
> TestAvroStorage seems to be the only user of this dependency at it seems to be working:
>
> ant clean test -Dtestcase=TestAvroStorage
>
>
> Thanks,
>
> Jarek Cecho
>
>