[jira] [Commented] (FLINK-9885) End-to-end test: Elasticsearch 6.x connector

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564765#comment-16564765 ] 

ASF GitHub Bot commented on FLINK-9885:
---------------------------------------

tzulitai commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#discussion_r206760543
 
 

 ##########
 File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java
 ##########
 @@ -97,6 +97,15 @@ public Builder(List<HttpHost> httpHosts, ElasticsearchSinkFunction<T> elasticsea
 			this.elasticsearchSinkFunction = Preconditions.checkNotNull(elasticsearchSinkFunction);
 		}
 
+		/**
+		 * Sets a map of strings that configures the bulk flushing behaviour.
+		 *
+		 * @param bulkRequestsConfig user configuration to configure bulk flushing behaviour.
+		 */
+		public void setBulkRequestsConfig(Map<String, String> bulkRequestsConfig) {
+			this.bulkRequestsConfig = bulkRequestsConfig;
 
 Review comment:
   My thought was just that it's more or less a convenience for users. In some scenarios, having a properties like setter would be easier to use. I'm completely ok with removing it, though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
>                 Key: FLINK-9885
>                 URL: https://issues.apache.org/jira/browse/FLINK-9885
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This should also come with an end-to-end test that covers this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)