You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "wecharyu (via GitHub)" <gi...@apache.org> on 2024/01/26 09:01:44 UTC
[PR] HIVE-28038: Disable fallback to jdo for DeadlineException [hive]
wecharyu opened a new pull request, #5040:
URL: https://github.com/apache/hive/pull/5040
### What changes were proposed in this pull request?
Mark `DeadlineException` as unrecoverable exception to avoid falling back to jdo query.
### Why are the changes needed?
`DeadlineException` should be terminated immediately, instead of falling back to jdo query.
https://github.com/apache/hive/blob/b75a59779dcf9c5ef74890c8916dbe9a2c13aef4/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java#L137-L142
### Does this PR introduce _any_ user-facing change?
No.
### Is the change a dependency upgrade?
No.
### How was this patch tested?
Passing test:
```bash
mvn test -Dtest=org.apache.hadoop.hive.metastore.TestObjectStore -pl :hive-standalone-metastore-server
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28038: Disable fallback to jdo for DeadlineException [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5040:
URL: https://github.com/apache/hive/pull/5040#issuecomment-1911824150
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5040) **Quality Gate passed**
The SonarCloud Quality Gate passed, but some issues were introduced.
[1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5040&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5040&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5040)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28038: Disable fallback to jdo for DeadlineException [hive]
Posted by "wecharyu (via GitHub)" <gi...@apache.org>.
wecharyu commented on code in PR #5040:
URL: https://github.com/apache/hive/pull/5040#discussion_r1475581467
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -52,9 +51,10 @@
* */
public class DatabaseProduct implements Configurable {
static final private Logger LOG = LoggerFactory.getLogger(DatabaseProduct.class.getName());
- private static final Class<SQLException>[] unrecoverableSqlExceptions = new Class[]{
- // TODO: collect more unrecoverable SQLExceptions
- SQLIntegrityConstraintViolationException.class
+ private static final Class<Exception>[] unrecoverableExceptions = new Class[]{
+ // TODO: collect more unrecoverable Exceptions
+ SQLIntegrityConstraintViolationException.class,
+ DeadlineException.class
Review Comment:
We may need avoid such bugs, and even if there was such bug, we should fail-fast because this call was already timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28038: Disable fallback to jdo for DeadlineException [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao merged PR #5040:
URL: https://github.com/apache/hive/pull/5040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org