You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2024/05/25 20:17:06 UTC

Re: [PR] migrate from Apache HttpClient 4 to Apache HttpClient 5 [pinot]

Jackie-Jiang commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1614852879


##########
pinot-common/pom.xml:
##########
@@ -161,6 +161,10 @@
       <groupId>org.apache.httpcomponents</groupId>
       <artifactId>httpmime</artifactId>
     </dependency>
+    <dependency>

Review Comment:
   Thanks for the great effort of this migration. After introducing httpclient5, do we still need to keep the dependency for http4 libraries?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org