You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/26 03:33:45 UTC
[GitHub] [apisix-docker] Yiyiyimu opened a new pull request #178: ci: change new release trigger from release to release branch
Yiyiyimu opened a new pull request #178:
URL: https://github.com/apache/apisix-docker/pull/178
Signed-off-by: yiyiyimu <wo...@gmail.com>
1. change new release trigger from release to release branch, to simplify new release publishment process
2. also push latest image when make release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #178: ci: change new release trigger from release to release branch
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #178:
URL: https://github.com/apache/apisix-docker/pull/178#discussion_r640947930
##########
File path: MAINTAINING.md
##########
@@ -0,0 +1,5 @@
+## New release
+
+To make and publish new docker images on docker hub, maintainers should create branch under `apisix-docker` repo with specific name.
+
+For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` seperately. Remember to delete the release branch after the new images published, since the branch would got no use afterwards.
Review comment:
I intended to add one, but since it would get deleted, I think naming it `release/apisix` or `release/apisix-v2.6` would makes no difference here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #178: ci: change new release trigger from release to release branch
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #178:
URL: https://github.com/apache/apisix-docker/pull/178#discussion_r640526557
##########
File path: MAINTAINING.md
##########
@@ -0,0 +1,5 @@
+## New release
+
+To make and publish new docker images on docker hub, maintainers should create branch under `apisix-docker` repo with specific name.
+
+For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` seperately. Remember to delete the release branch after the new images published, since the branch would got no use afterwards.
Review comment:
It would be better to add some examples about the branch name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #178: ci: change new release trigger from release to release branch
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #178:
URL: https://github.com/apache/apisix-docker/pull/178#discussion_r641215072
##########
File path: MAINTAINING.md
##########
@@ -0,0 +1,5 @@
+## New release
+
+To make and publish new docker images on docker hub, maintainers should create branch under `apisix-docker` repo with specific name.
+
+For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` seperately. Remember to delete the release branch after the new images published, since the branch would got no use afterwards.
Review comment:
I mean:
```suggestion
For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` separately (e.g. `release/apisix-2.6`, `release/dashboard-2.6`). Remember to delete the release branch after the new images published, since the branch would got no use afterwards.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu merged pull request #178: ci: change new release trigger from release to release branch
Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #178:
URL: https://github.com/apache/apisix-docker/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org