[GitHub] [ozone] adoroszlai commented on a diff in pull request #4094: HDDS-7648. Add a servername tag in UGI metrics.

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #4094:
URL: https://github.com/apache/ozone/pull/4094#discussion_r1050036551


##########
hadoop-hdds/framework/pom.xml:
##########
@@ -29,7 +29,16 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
   <name>Apache Ozone HDDS Server Framework</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <ozone-common.version>1.3.0-SNAPSHOT</ozone-common.version>
+  </properties>
+
   <dependencies>
+    <dependency>
+      <groupId>org.apache.ozone</groupId>
+      <artifactId>ozone-common</artifactId>
+      <version>${ozone-common.version}</version>
+    </dependency>

Review Comment:
   Please do not introduce backwards dependency (`hdds -> ozone`).  If we want to access some code currently in `ozone` from both, we should move it to `hdds`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org