You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "XieXianshan (JIRA)" <ji...@apache.org> on 2011/06/22 04:18:47 UTC
[jira] [Created] (MAPREDUCE-2612) The result returned by the wrong
usage of the command "job -counter "is
not appropriate
The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
---------------------------------------------------------------------------------------------------------------------------
Key: MAPREDUCE-2612
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
Project: Hadoop Map/Reduce
Issue Type: Improvement
Affects Versions: 0.23.0
Reporter: XieXianshan
Priority: Minor
Fix For: 0.23.0
The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
It is very easy to be misunderstood if users just make a spelling mistake.
So,for more comprehensible information, more detailed results should be displayed as the following:
[Could not find group FileSystemCounters_err] <--incorrect group name
or
[Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2612) The result returned by the wrong
usage of the command "job -counter "is
not appropriate
Posted by "XieXianshan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
XieXianshan updated MAPREDUCE-2612:
-----------------------------------
Attachment: Mapreduce_2612
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2612) The result returned by the
wrong usage of the command "job -counter
"is not appropriate
Posted by "XieXianshan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055430#comment-13055430 ]
XieXianshan commented on MAPREDUCE-2612:
----------------------------------------
Thanks for your comment.I reupload the patch.
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2612-0627, Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2612) The result returned by the wrong
usage of the command "job -counter "is
not appropriate
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2612:
-----------------------------------
Status: Open (was: Patch Available)
This patch doesn't seem like a good idea to me.
Counters are constructed on-demand. So, the non-existence of a counter is indeed equivalent to the value 0. For example, if running a job where some counters are incremented only in reducers, and the reducers haven't started yet, we don't want to throw error messages if the user is trying to fetch those counters.
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2612-0627, Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2612) The result returned by the
wrong usage of the command "job -counter
"is not appropriate
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055177#comment-13055177 ]
Harsh J commented on MAPREDUCE-2612:
------------------------------------
Patch LGTM. But may be breaking tests or compatibility here (since earlier behavior was not to return an error). Can tests be added and/or updated where appropriate?
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2612) The result returned by the
wrong usage of the command "job -counter
"is not appropriate
Posted by "XieXianshan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056956#comment-13056956 ]
XieXianshan commented on MAPREDUCE-2612:
----------------------------------------
Stacktrace:
org.apache.hadoop.fs.shell.CommandFormat$TooManyArgumentsException: Too many arguments: expected 2 but got 3
at org.apache.hadoop.fs.shell.CommandFormat.parse(CommandFormat.java:113)
at org.apache.hadoop.fs.shell.CommandFormat.parse(CommandFormat.java:77)
at org.apache.hadoop.fs.TestFileSystem.testCommandFormat(TestFileSystem.java:97)
These failures are still displayed in my dev environment without this patch.
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2612-0627, Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2612) The result returned by the
wrong usage of the command "job -counter
"is not appropriate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055518#comment-13055518 ]
Hadoop QA commented on MAPREDUCE-2612:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483920/MAPREDUCE-2612-0627
against trunk revision 1139400.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/427//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/427//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/427//console
This message is automatically generated.
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2612-0627, Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2612) The result returned by the wrong
usage of the command "job -counter "is
not appropriate
Posted by "XieXianshan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
XieXianshan updated MAPREDUCE-2612:
-----------------------------------
Attachment: MAPREDUCE-2612-0627
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2612-0627, Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2612) The result returned by the
wrong usage of the command "job -counter
"is not appropriate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053043#comment-13053043 ]
Hadoop QA commented on MAPREDUCE-2612:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483397/Mapreduce_2612
against trunk revision 1137017.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
org.apache.hadoop.mapred.TestJobClient
org.apache.hadoop.mapred.TestSeveral
org.apache.hadoop.mapreduce.TestMRJobClient
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/410//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/410//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/410//console
This message is automatically generated.
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2612) The result returned by the wrong
usage of the command "job -counter "is
not appropriate
Posted by "XieXianshan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
XieXianshan updated MAPREDUCE-2612:
-----------------------------------
Status: Patch Available (was: Open)
> The result returned by the wrong usage of the command "job -counter<job-id> <group-name> <counter-name> "is not appropriate
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2612
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2612
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: XieXianshan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: Mapreduce_2612
>
>
> The result returned by Map/Reduce command "job -counter<job-id> <group-name> <counter-name> " is always zero ,when use this command with incorrect group name or counter name.
> It is very easy to be misunderstood if users just make a spelling mistake.
> So,for more comprehensible information, more detailed results should be displayed as the following:
> [Could not find group FileSystemCounters_err] <--incorrect group name
> or
> [Could not find counter FILE_BYTES_READ_err in the group FileSystemCounters] <--incorrect counter name
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira