You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "andreykot (via GitHub)" <gi...@apache.org> on 2023/02/26 01:37:43 UTC
[GitHub] [beam] andreykot opened a new pull request, #25633: Fix example code on from-spark.md
andreykot opened a new pull request, #25633:
URL: https://github.com/apache/beam/pull/25633
The following example with Python code for Beam is invalid in the [documentation](https://beam.apache.org/get-started/from-spark/#using-calculated-values):
```python
import apache_beam as beam
with beam.Pipeline() as pipeline:
values = pipeline | beam.Create([1, 2, 3, 4])
min_value = values | beam.CombineGlobally(min)
max_value = values | beam.CombineGlobally(max)
# To access `total`, we need to pass it as a side input.
scaled_values = values | beam.Map(
lambda x, min_value, max_value: x / lambda x: (x - min_value) / (max_value - min_value),
min_value =beam.pvalue.AsSingleton(min_value),
max_value =beam.pvalue.AsSingleton(max_value))
scaled_values | beam.Map(print)
```
Python interpreter returns **SyntaxError** during the execution of this code:
```bash
File "playground/spark_side_inputs.py", line 10
lambda x, min_value, max_value: x / lambda x: (x - min_value) / (max_value - min_value),
^
SyntaxError: invalid syntax
```
In this PR, I fix this code block to make it valid for Python interpreter.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #25633: Fix example code on from-spark.md
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay merged PR #25633:
URL: https://github.com/apache/beam/pull/25633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25633: Fix example code on from-spark.md
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25633:
URL: https://github.com/apache/beam/pull/25633#issuecomment-1446681703
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreykot commented on pull request #25633: Fix example code on from-spark.md
Posted by "andreykot (via GitHub)" <gi...@apache.org>.
andreykot commented on PR #25633:
URL: https://github.com/apache/beam/pull/25633#issuecomment-1446679785
Add Python reviewers from https://github.com/apache/beam/blob/master/OWNERS
R: @pabloem
R: @robertwb
R: @aaltay
R: @charlesccychen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org