[GitHub] [flink] JingsongLi commented on a change in pull request #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask
URL: https://github.com/apache/flink/pull/8961#discussion_r299808496
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/dataformat/BinaryRowTest.java
 ##########
 @@ -294,6 +294,12 @@ public void anyNullTest() throws IOException {
 			BinaryRowWriter writer = new BinaryRowWriter(row);
 			assertFalse(row.anyNull());
 
+			writer.setNullAt(24);
+			assertTrue(row.anyNull());
+
+			writer.setNullAt(55);
 
 Review comment:
   This is useless, because the previous `setNull` has allowed `anyNull` to return to true.
   How about add a test:
   ```
   int numFields = 80;
   			for (int i = 0; i < numFields; i++) {
   				BinaryRow row = new BinaryRow(80);
   				BinaryRowWriter writer = new BinaryRowWriter(row);
   				assertFalse(row.anyNull());
   				writer.setNullAt(i);
   				assertTrue(row.anyNull());
   			}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services