You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/25 15:34:37 UTC
[PR] fix: sequence audit log filter requests [rocketmq-dashboard]
tju-yxq opened a new pull request, #2592:
URL: https://github.com/apache/rocketmq-dashboard/pull/2592
Closes #2591
## Summary
- sequence audit record requests with a request-generation ref and ignore stale success, error, and loading updates
- sequence filter-option requests so an older cleanup refresh cannot replace newer options
- make loading reliably track the latest record request without a synchronous setState in the effect body
- build one debounced active filter object and use it for both table queries and CSV export
- recover to the last valid page when a filter change returns an empty page while the server total is still positive
## Why
Each effect previously used an independent local `cancelled` flag. A slow earlier request could resolve after a newer filtered request started and overwrite the newer result. Export also used the raw search input while the table used the debounced value, so clicking export immediately after typing could produce a CSV for a different filter than the visible table.
## Tests
- focused: `AuditPage.test.tsx` — 6 tests passed
- `npm run lint -- --quiet`: 0 errors, 2 pre-existing warnings
- `npm run build`: passed
- `git diff --check`: passed
Production changes: 48 additions / 27 deletions. The full PR is 94 additions / 28 deletions. This is a real correctness fix, but production changed lines are below the separate 100-line target, so it is recorded as a candidate rather than counted as a complete group in the tracking ledger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: sequence audit log filter requests [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2592:
URL: https://github.com/apache/rocketmq-dashboard/pull/2592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org