[GitHub] [arrow] cyb70289 commented on a change in pull request #12574: ARROW-15854: [C++] Refine CSV writer code

[GitBox <gi...@apache.org>]

cyb70289 commented on a change in pull request #12574:
URL: https://github.com/apache/arrow/pull/12574#discussion_r820218686



##########
File path: cpp/src/arrow/csv/writer.cc
##########
@@ -117,17 +116,16 @@ class ColumnPopulator {
   }
 
   // Places string data onto each row in output and updates the corresponding row
-  // pointers in preparation for calls to other (preceding) ColumnPopulators.
+  // pointers in preparation for calls to other (next) ColumnPopulators.
   // Implementations may apply certain checks e.g. for illegal values, which in case of
   // failure causes this function to return an error Status.
   // Args:
   //   output: character buffer to write to.
-  //   offsets: an array of end of row column within the the output buffer (values are
-  //   one past the end of the position to write to).
-  virtual Status PopulateColumns(char* output, int32_t* offsets) const = 0;
+  //   offsets: an array of start of row column within the output buffer.
+  virtual Status PopulateRows(char* output, int64_t* offsets) const = 0;

Review comment:
       Name `PopulateColumns` is a bit confusing IMO as this function writes rows of a single column to csv output buffer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org