You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/08/02 12:45:34 UTC

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3382: [Improvement][server] server model ProcessUtils.java code cleaning.

yangyichao-mango commented on a change in pull request #3382:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3382#discussion_r464073072



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ProcessUtils.java
##########
@@ -283,10 +275,8 @@ private static boolean needsEscaping(int verificationType, String arg) {
    * @param logger      logger
    * @param tenantCode  tenant code
    * @param executePath     execute path
-   * @throws IOException io exception
    */
-  public static void cancelApplication(List<String> appIds, Logger logger, String tenantCode,String executePath)
-          throws IOException {
+  public static void cancelApplication(List<String> appIds, Logger logger, String tenantCode,String executePath) {

Review comment:
       ```suggestion
     public static void cancelApplication(List<String> appIds, Logger logger, String tenantCode, String executePath) {
   ```
   Hi,
   Please configure the checkstyle.xml and codestyle plugin to your ide. It will help to format the code.
   [1] https://github.com/apache/incubator-dolphinscheduler/blob/dev/style/checkstyle.xml
   [2] https://github.com/apache/incubator-dolphinscheduler/blob/dev/style/intellij-java-code-style.xml




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org