You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/17 13:44:26 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4352: Kconfig: add NuttX License setup

gustavonihei commented on a change in pull request #4352:
URL: https://github.com/apache/incubator-nuttx/pull/4352#discussion_r690384965



##########
File path: Kconfig
##########
@@ -9,6 +9,19 @@ config APPSDIR
 	string
 	option env="APPSDIR"
 
+menu "License Setup"
+config ALLOW_GPL_COMPONENTS
+	bool "Use components that have GPL/LGPL licenses"
+	default n
+	---help---
+		When this option is enabled the project will use components

Review comment:
       ```suggestion
   		When this option is enabled the project will allow the use of components
   ```
   "The project will use" is a bit misleading, since the new allowed components may not be auto-selected.

##########
File path: Kconfig
##########
@@ -9,6 +9,19 @@ config APPSDIR
 	string
 	option env="APPSDIR"
 
+menu "License Setup"
+config ALLOW_GPL_COMPONENTS
+	bool "Use components that have GPL/LGPL licenses"
+	default n
+	---help---
+		When this option is enabled the project will use components

Review comment:
       ```suggestion
   		When this option is enabled the project will allow the selection of components
   ```
   "The project will use" is a bit misleading, since the new allowed components may not be auto-selected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org