You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2010/08/07 11:31:47 UTC
[jira] Created: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
@WebFault interceptor to map exceptions to faults
-------------------------------------------------
Key: CAMEL-3033
URL: https://issues.apache.org/activemq/browse/CAMEL-3033
Project: Apache Camel
Issue Type: New Feature
Components: camel-core
Reporter: Claus Ibsen
Priority: Minor
Fix For: Future
Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
See nabble
http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61100#action_61100 ]
Savas Ali Tokmen commented on CAMEL-3033:
-----------------------------------------
I believe this feature is CXF-specific and will therefore not modify camel-core. Since the @WebFault is part of the JAX-WS 2.x spec, itself implemented by CXF, no extra JARs need to be included for camel-cxf.
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savas Ali Tokmen updated CAMEL-3033:
------------------------------------
Attachment: (was: camel-3033_webfault_annotated_exception_to_soapfault.patch)
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61147#action_61147 ]
Willem Jiang commented on CAMEL-3033:
-------------------------------------
Hi Savas,
I went through your patch, just few comments here.
If you take a look at CXF FaultOutInterceptor and WebFaultOutInterceptor, you will find CXF already did that kind of thing for you.
Such as setting the fault message with fault cause message , and building up the fault detail, all you need to do is make sure that
your fault is thrown rightly from CxfConsumer.
For the test part , you don't change anything the verification part of CXF test code, which means you patch didn't improve any thing.
Can you write a small test case to demonstrate that current camel-cxf can't handle the fault rightly?
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61096#action_61096 ]
Claus Ibsen commented on CAMEL-3033:
------------------------------------
There is code in the nabble thread which shows how to do this. I am sure the reporter would gladly donate the code to Apache if requested to do so.
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang updated CAMEL-3033:
--------------------------------
Component/s: camel-cxf
(was: camel-core)
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-cxf
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savas Ali Tokmen updated CAMEL-3033:
------------------------------------
Attachment: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
Hello Willem
Of course you're right, this approach will also avoid touching test classes unnecessarily.
Attaching new patch, with therefore only the modified CxfConsumer and the new test that uses org.apache.cxf.greeter_control.Greeter that throws an org.apache.cxf.greeter_control.PingMeFault.
The test of course does not pass if you do not patch CxfConsumer.
Cheers
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch, camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savas Ali Tokmen updated CAMEL-3033:
------------------------------------
Attachment: camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch
Hello Willem
You're right, I forgot to include the test in the patch! Now adding in a second patch file. Sorry. Should be better now :)
If you try the test WITHOUT the patch on CxfConsumer.java, the test is supposed to fail.
Cheers
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault.patch, camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61302#action_61302 ]
Willem Jiang commented on CAMEL-3033:
-------------------------------------
Hi Savas
I tried to apply your patch into the chunk, and did some improvement to fix the unit tests of camel-cxf.
Now it should be fine, please check it out to verify with your application.
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61308#action_61308 ]
Willem Jiang commented on CAMEL-3033:
-------------------------------------
@Savas,
It's done :)
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-cxf
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-3033.
---------------------------------
Fix Version/s: 2.5.0
(was: Future)
Resolution: Fixed
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-3033:
-----------------------------------
Assignee: Willem Jiang
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61326#action_61326 ]
Savas Ali Tokmen commented on CAMEL-3033:
-----------------------------------------
Awesome :)
Thank you
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-cxf
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savas Ali Tokmen updated CAMEL-3033:
------------------------------------
Attachment: (was: camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch)
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61295#action_61295 ]
Savas Ali Tokmen commented on CAMEL-3033:
-----------------------------------------
Hello Willem
I see you've assigned this issue to yourself, is it planned for CAMEL 2.5.0?
Also, I guess updating the component to camel-cxf would be a good thing to do :)
Cheers
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-3033) @WebFault interceptor to
map exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61150#action_61150 ]
Savas Ali Tokmen edited comment on CAMEL-3033 at 8/11/10 5:33 AM:
------------------------------------------------------------------
Hello Willem
You're right, I forgot to include the test in the patch! Now adding in a second patch file. Sorry. Should be better now :)
If you try the test WITHOUT the patch on CxfConsumer.java, the test is supposed to fail: since the CXF default Fault generator does not parse the @WebFault annotations, the thrown Fault is a generic fault and the CXF client does not recognize it.
Cheers
was (Author: alitokmen):
Hello Willem
You're right, I forgot to include the test in the patch! Now adding in a second patch file. Sorry. Should be better now :)
If you try the test WITHOUT the patch on CxfConsumer.java, the test is supposed to fail.
Cheers
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61152#action_61152 ]
Willem Jiang commented on CAMEL-3033:
-------------------------------------
Hi Savas,
Here is a thing for you new test case, as you are using HelloService which has no @WebService annotation, camel-cxf will use the simple front end instead of the JAXWS front end. The WebFaultOutInterceptor will not be a part of interceptor chain, so it make sense that it ignore the @WebFault annotation.
Can you try to write a test which uses the Greeter interface?
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savas Ali Tokmen updated CAMEL-3033:
------------------------------------
Attachment: camel-3033_webfault_annotated_exception_to_soapfault.patch
Attached patch that adds the functionality that enables CAMEL-CXF to generate an adequate SOAP Fault when the Exception thrown by a CAMEL exchange has a JAX-WS @WebFault annotation.
The patch also adds in a test that checks that things keep on working great.
I'm of course happily donating this code to Apache CAMEL.
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3033) @WebFault interceptor to map
exceptions to faults
Posted by "Savas Ali Tokmen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61307#action_61307 ]
Savas Ali Tokmen commented on CAMEL-3033:
-----------------------------------------
Thank you Willem for the patch. Looks good on my side.
A minor comment: can you please change the issue's component to camel-cxf? It still is camel-core, which is incorrect.
Cheers
> @WebFault interceptor to map exceptions to faults
> -------------------------------------------------
>
> Key: CAMEL-3033
> URL: https://issues.apache.org/activemq/browse/CAMEL-3033
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: camel-3033_webfault_annotated_exception_to_soapfault_with_jaxws_endpoint_test.patch
>
>
> Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should offer the reverse.
> The @WebFault is a standard annotation. The interceptor should then introspect the thrown exception and see if its annotated with @WebFault. If so it should turn the exception into a fault message.
> See nabble
> http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html
> It should be possible to include in camel-core as annotations jars is optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.