[jira] [Commented] (HIVE-13342) Improve logging in llap decider for llap

["Vikram Dixit K (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230950#comment-15230950 ] 

Vikram Dixit K commented on HIVE-13342:
---------------------------------------

[~sseth] Yes. The other log lines should tell us which operator interferes with running in llap. I changed the exception to use the right configuration variable from HiveConf. However, there is currently no way to get the values a configuration can take from code.

I think it is better to not add more configuration to enable/disable the mode = all behavior. If the user is not sure if they can run in llap, they need to use mode = auto. The mode = all behavior only prevents further checking on the query if it can be run in llap. If under mode all, query cannot be run in llap because some parts of the plan cannot be run in it, it makes sense to stop the user from proceeding. If you feel strongly about needing the flag, I can add one but I am not convinced at this point in time.

> Improve logging in llap decider for llap
> ----------------------------------------
>
>                 Key: HIVE-13342
>                 URL: https://issues.apache.org/jira/browse/HIVE-13342
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 2.1.0
>            Reporter: Vikram Dixit K
>            Assignee: Vikram Dixit K
>         Attachments: HIVE-13342.1.patch, HIVE-13342.2.patch
>
>
> Currently we do not log our decisions with respect to llap. Are we running everything in llap mode or only parts of the plan. We need more logging. Also, if llap mode is all but for some reason, we cannot run the work in llap mode, fail and throw an exception advise the user to change the mode to auto.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)