You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/12 09:04:00 UTC
[GitHub] [hbase] Apache9 opened a new pull request #1280: HBASE-23799 Make
our core coprocessors use shaded protobuf
Apache9 opened a new pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598680222
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 33s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 13s | master passed |
| +1 :green_heart: | compile | 5m 57s | master passed |
| +1 :green_heart: | shadedjars | 7m 19s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 32s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 2s | the patch passed |
| +1 :green_heart: | compile | 5m 49s | the patch passed |
| +1 :green_heart: | javac | 5m 49s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 27s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 6s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 32s | hbase-client in the patch passed. |
| -1 :x: | unit | 7m 57s | hbase-server in the patch failed. |
| -1 :x: | unit | 4m 10s | hbase-endpoint in the patch failed. |
| +1 :green_heart: | unit | 1m 17s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 48s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 45s | hbase-examples in the patch passed. |
| | | 78m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b2070997936e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1b163d98b9 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-endpoint.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/testReport/ |
| Max. process+thread count | 2756 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394099616
##########
File path: hbase-protocol-shaded/src/main/protobuf/AccessControl.proto
##########
@@ -128,6 +128,15 @@ message HasUserPermissionsResponse {
repeated bool has_user_permission = 1;
}
+message HasPermissionRequest {
+ required TablePermission table_permission = 1;
+ required bytes user_name = 2;
+}
Review comment:
Missing from hbase-protocol-shaded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598103225
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 41s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 24s | master passed |
| +1 :green_heart: | compile | 4m 2s | master passed |
| +1 :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 27s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 21s | hbase-examples in master failed. |
| -0 :warning: | javadoc | 0m 23s | hbase-rest in master failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 19s | the patch passed |
| +1 :green_heart: | compile | 3m 58s | the patch passed |
| +1 :green_heart: | javac | 3m 59s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 23s | hbase-rest in the patch failed. |
| -0 :warning: | javadoc | 0m 19s | hbase-examples in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 56s | hbase-protocol-shaded in the patch passed. |
| -0 :warning: | unit | 0m 43s | hbase-client in the patch failed. |
| -0 :warning: | unit | 4m 55s | hbase-server in the patch failed. |
| -0 :warning: | unit | 2m 47s | hbase-endpoint in the patch failed. |
| -0 :warning: | unit | 0m 59s | hbase-rest in the patch failed. |
| +1 :green_heart: | unit | 1m 13s | hbase-examples in the patch passed. |
| | | 52m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 52fde5dc8ccf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 26f3702735 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-endpoint.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/testReport/ |
| Max. process+thread count | 3589 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598706498
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 11s | master passed |
| +1 :green_heart: | compile | 4m 48s | master passed |
| +1 :green_heart: | shadedjars | 5m 36s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 22s | hbase-examples in master failed. |
| -0 :warning: | javadoc | 0m 22s | hbase-rest in master failed. |
| -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 14s | the patch passed |
| +1 :green_heart: | compile | 4m 54s | the patch passed |
| +1 :green_heart: | javac | 4m 54s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 38s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. |
| -0 :warning: | javadoc | 0m 18s | hbase-examples in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 13s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 99m 58s | hbase-server in the patch passed. |
| -0 :warning: | unit | 2m 57s | hbase-endpoint in the patch failed. |
| +1 :green_heart: | unit | 1m 4s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 3m 5s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 43s | hbase-examples in the patch passed. |
| | | 156m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7cefc4f4cd09 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1b163d98b9 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-endpoint.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/testReport/ |
| Max. process+thread count | 4391 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598866258
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 34s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 2s | master passed |
| +1 :green_heart: | compile | 4m 4s | master passed |
| +1 :green_heart: | shadedjars | 6m 18s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 53s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 26s | the patch passed |
| +1 :green_heart: | compile | 4m 17s | the patch passed |
| +1 :green_heart: | javac | 4m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 21s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 14s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 0s | hbase-client in the patch passed. |
| -1 :x: | unit | 100m 26s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 5m 9s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 3m 16s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 8m 51s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 4m 22s | hbase-examples in the patch passed. |
| | | 172m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d70ff6769535 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/testReport/ |
| Max. process+thread count | 3954 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395123809
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1985,21 +1985,20 @@ public SecurityCapabilitiesResponse getSecurityCapabilities(RpcController contro
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.AccessControlService.Interface}.
+ * {@link AccessControlService.Interface}.
*/
boolean hasAccessControlServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class), AccessControlService.Interface.class);
+ return checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ AccessControlService.Interface.class);
}
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos.VisibilityLabelsService.Interface}.
+ * {@link VisibilityLabelsService.Interface}.
*/
boolean hasVisibilityLabelsServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class),
- VisibilityLabelsService.Interface.class);
+ return checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ VisibilityLabelsService.Interface.class);
}
/**
Review comment:
if you use the CP client to talk to hbase3 then it should be fire, the shaded and non-shaded version are wire compatible, but the CPs at server side should be recompiled to make use of the shaded protobuf version. This maybe a bit difficult for users, we should tell user how to do the replacement on the generated protobuf classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395121253
##########
File path: hbase-protocol-shaded/src/main/protobuf/AccessControl.proto
##########
@@ -128,6 +128,15 @@ message HasUserPermissionsResponse {
repeated bool has_user_permission = 1;
}
+message HasPermissionRequest {
+ required TablePermission table_permission = 1;
+ required bytes user_name = 2;
+}
Review comment:
Yes. This is only used in CPEP in the past.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395119064
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/Coprocessor.java
##########
@@ -21,11 +21,11 @@
import java.io.IOException;
import java.util.Collections;
-
-import com.google.protobuf.Service;
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.yetus.audience.InterfaceStability;
+import org.apache.hbase.thirdparty.com.google.protobuf.Service;
+
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395120003
##########
File path: hbase-endpoint/pom.xml
##########
@@ -47,24 +47,6 @@
<skipAssembly>true</skipAssembly>
</configuration>
</plugin>
- <plugin>
- <groupId>org.xolstice.maven.plugins</groupId>
- <artifactId>protobuf-maven-plugin</artifactId>
- <executions>
- <execution>
- <id>compile-protoc</id>
- <phase>generate-sources</phase>
- <goals>
- <goal>compile</goal>
- </goals>
- <configuration>
- <additionalProtoPathElements>
- <additionalProtoPathElement>${basedir}/../hbase-protocol/src/main/protobuf</additionalProtoPathElement>
- </additionalProtoPathElements>
- </configuration>
- </execution>
- </executions>
- </plugin>
Review comment:
All in hbase-protocol-shaded, as we need to some relocation and replacement in code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r393907627
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java
##########
@@ -71,6 +65,13 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors.MethodDescriptor;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+import org.apache.hbase.thirdparty.com.google.protobuf.RpcCallback;
+import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel;
+import org.apache.hbase.thirdparty.com.google.protobuf.RpcController;
+import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException;
Review comment:
Ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r393908442
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java
##########
@@ -35,6 +34,7 @@
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel;
Review comment:
Yeah, ditto. These are public classes. This stuff is used internally so should be fine just changing it... its just that hbase-shaded-protobuf needs to be on the CLASSPATH? I suppose it was anyways?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394098972
##########
File path: hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java
##########
@@ -20,22 +20,14 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-import com.google.protobuf.RpcCallback;
-import com.google.protobuf.RpcController;
-import com.google.protobuf.Service;
Review comment:
Yeah, so client now has to have hbase-shaded-protobuf on its side and if we change internal pb version we could break the endpoint?
Realistically, the pb3 should probably stay on-the-wire compat so should be concern till pb4 or until we decided we want our pbs to be schema v3 compat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394016223
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
##########
@@ -124,7 +125,7 @@ public void initialize(EmptyMsg msg) {
private BigDecimalMsg getProtoForType(BigDecimal t) {
BigDecimalMsg.Builder builder = BigDecimalMsg.newBuilder();
- return builder.setBigdecimalMsg(ByteStringer.wrap(Bytes.toBytes(t))).build();
+ return builder.setBigdecimalMsg(UnsafeByteOperations.unsafeWrap(Bytes.toBytes(t))).build();
Review comment:
Good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395122159
##########
File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
##########
@@ -77,6 +73,10 @@
import org.slf4j.LoggerFactory;
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+import org.apache.hbase.thirdparty.com.google.protobuf.Service;
+import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException;
/**
* HTable interface to remote tables accessed via REST gateway
Review comment:
No? It is the Table implementation for rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394097852
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/ClientTokenUtil.java
##########
@@ -69,7 +70,7 @@ private static void injectFault() throws ServiceException {
AsyncConnection conn) {
CompletableFuture<Token<AuthenticationTokenIdentifier>> future = new CompletableFuture<>();
if (injectedException != null) {
- future.completeExceptionally(injectedException);
+ future.completeExceptionally(ProtobufUtil.handleRemoteException(injectedException));
Review comment:
Needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394097610
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcUtils.java
##########
@@ -87,53 +89,47 @@ public static CoprocessorServiceRequest getCoprocessorServiceRequest(
}
public static CoprocessorServiceRequest getCoprocessorServiceRequest(
- final Descriptors.MethodDescriptor method, final Message request, final byte [] row,
- final byte [] regionName) {
- return CoprocessorServiceRequest.newBuilder().setCall(
- getCoprocessorServiceCall(method, request, row)).
- setRegion(RequestConverter.buildRegionSpecifier(REGION_NAME, regionName)).build();
+ final Descriptors.MethodDescriptor method, final Message request, final byte[] row,
+ final byte[] regionName) {
+ return CoprocessorServiceRequest.newBuilder()
+ .setCall(getCoprocessorServiceCall(method, request, row))
+ .setRegion(RequestConverter.buildRegionSpecifier(REGION_NAME, regionName)).build();
}
- private static CoprocessorServiceCall getCoprocessorServiceCall(
- final Descriptors.MethodDescriptor method, final Message request, final byte [] row) {
+ private static CoprocessorServiceCall getCoprocessorServiceCall(final MethodDescriptor method,
+ final Message request, final byte[] row) {
return CoprocessorServiceCall.newBuilder()
- .setRow(org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.unsafeWrap(row))
- .setServiceName(CoprocessorRpcUtils.getServiceName(method.getService()))
- .setMethodName(method.getName())
- // TODO!!!!! Come back here after!!!!! This is a double copy of the request if I read
- // it right copying from non-shaded to shaded version!!!!!! FIXXXXX!!!!!
- .setRequest(org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.
- unsafeWrap(request.toByteArray())).build();
+ .setRow(org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.unsafeWrap(row))
+ .setServiceName(CoprocessorRpcUtils.getServiceName(method.getService()))
+ .setMethodName(method.getName())
+ // TODO!!!!! Come back here after!!!!! This is a double copy of the request if I read
+ // it right copying from non-shaded to shaded version!!!!!! FIXXXXX!!!!!
Review comment:
Did I write this comment?
In CPEP, there was copying from pb2.5 data structures to internal PB3 data structures -- so we could maintain pb2.5 as public interface but this seems to be something different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395120910
##########
File path: hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java
##########
@@ -20,22 +20,14 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-import com.google.protobuf.RpcCallback;
-import com.google.protobuf.RpcController;
-import com.google.protobuf.Service;
Review comment:
In previous discussion the idea is to keep the protobuf version 'stable' for a whole major release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598103638
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 1s | master passed |
| +1 :green_heart: | compile | 3m 51s | master passed |
| +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 13s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 52s | the patch passed |
| +1 :green_heart: | compile | 3m 47s | the patch passed |
| +1 :green_heart: | javac | 3m 47s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 26s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 40s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 43s | hbase-client in the patch failed. |
| -1 :x: | unit | 6m 30s | hbase-server in the patch failed. |
| -1 :x: | unit | 2m 48s | hbase-endpoint in the patch failed. |
| -1 :x: | unit | 1m 21s | hbase-rest in the patch failed. |
| +1 :green_heart: | unit | 1m 25s | hbase-examples in the patch passed. |
| | | 53m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux ce0bd4c3e5e9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 26f3702735 |
| Default Java | 1.8.0_232 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-endpoint.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rest.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/testReport/ |
| Max. process+thread count | 2421 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598511558
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 19s | master passed |
| +1 :green_heart: | compile | 3m 30s | master passed |
| +1 :green_heart: | shadedjars | 4m 50s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 6s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 10s | the patch passed |
| +1 :green_heart: | compile | 3m 26s | the patch passed |
| +1 :green_heart: | javac | 3m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 52s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 35s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 43s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 38s | hbase-client in the patch failed. |
| -1 :x: | unit | 6m 51s | hbase-server in the patch failed. |
| -1 :x: | unit | 3m 18s | hbase-endpoint in the patch failed. |
| -1 :x: | unit | 1m 16s | hbase-rest in the patch failed. |
| +1 :green_heart: | unit | 1m 42s | hbase-examples in the patch passed. |
| | | 49m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux bcd8b61123e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1b163d98b9 |
| Default Java | 1.8.0_232 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-endpoint.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rest.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/testReport/ |
| Max. process+thread count | 3034 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394100184
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1985,21 +1985,20 @@ public SecurityCapabilitiesResponse getSecurityCapabilities(RpcController contro
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.AccessControlService.Interface}.
+ * {@link AccessControlService.Interface}.
*/
boolean hasAccessControlServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class), AccessControlService.Interface.class);
+ return checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ AccessControlService.Interface.class);
}
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos.VisibilityLabelsService.Interface}.
+ * {@link VisibilityLabelsService.Interface}.
*/
boolean hasVisibilityLabelsServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class),
- VisibilityLabelsService.Interface.class);
+ return checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ VisibilityLabelsService.Interface.class);
}
/**
Review comment:
What happens when an old CP impl tries to go against hbase3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598111828
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 5s | master passed |
| +1 :green_heart: | checkstyle | 2m 59s | master passed |
| -1 :x: | spotbugs | 2m 26s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 45s | the patch passed |
| -0 :warning: | checkstyle | 0m 36s | hbase-client: The patch generated 3 new + 217 unchanged - 19 fixed = 220 total (was 236) |
| -0 :warning: | checkstyle | 1m 27s | hbase-server: The patch generated 1 new + 634 unchanged - 26 fixed = 635 total (was 660) |
| -0 :warning: | checkstyle | 0m 13s | hbase-endpoint: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -0 :warning: | whitespace | 0m 0s | The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 21m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 3m 21s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 19s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 3s | The patch does not generate ASF License warnings. |
| | | 72m 59s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml cc hbaseprotoc prototool |
| uname | Linux 11690312b1b2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 26f3702735 |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-endpoint.txt |
| whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 83 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395119694
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java
##########
@@ -35,6 +34,7 @@
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel;
Review comment:
It has to be on the classpath, for normal read write we will make use of the shaded protobuf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598514779
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 2s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 19s | master passed |
| +1 :green_heart: | checkstyle | 2m 57s | master passed |
| -1 :x: | spotbugs | 1m 58s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 16s | the patch passed |
| -0 :warning: | checkstyle | 0m 35s | hbase-client: The patch generated 3 new + 217 unchanged - 19 fixed = 220 total (was 236) |
| -0 :warning: | checkstyle | 1m 23s | hbase-server: The patch generated 1 new + 634 unchanged - 26 fixed = 635 total (was 660) |
| -0 :warning: | checkstyle | 0m 13s | hbase-endpoint: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -0 :warning: | whitespace | 0m 0s | The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 16m 22s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 3m 17s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 4s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. |
| | | 64m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml cc hbaseprotoc prototool |
| uname | Linux 52f3daae7db0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1b163d98b9 |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-endpoint.txt |
| whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 93 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598516772
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 3s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 31s | master passed |
| +1 :green_heart: | compile | 5m 18s | master passed |
| +1 :green_heart: | shadedjars | 7m 5s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 32s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 25s | hbase-examples in master failed. |
| -0 :warning: | javadoc | 0m 28s | hbase-rest in master failed. |
| -0 :warning: | javadoc | 0m 51s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 9m 16s | the patch passed |
| +1 :green_heart: | compile | 5m 40s | the patch passed |
| +1 :green_heart: | javac | 5m 40s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 53s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 34s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 53s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 26s | hbase-rest in the patch failed. |
| -0 :warning: | javadoc | 0m 22s | hbase-examples in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 9s | hbase-protocol-shaded in the patch passed. |
| -0 :warning: | unit | 0m 59s | hbase-client in the patch failed. |
| -0 :warning: | unit | 8m 59s | hbase-server in the patch failed. |
| -0 :warning: | unit | 3m 10s | hbase-endpoint in the patch failed. |
| -0 :warning: | unit | 1m 28s | hbase-rest in the patch failed. |
| +1 :green_heart: | unit | 1m 53s | hbase-examples in the patch passed. |
| | | 73m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 602e8b6b8ec8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1b163d98b9 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-endpoint.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/testReport/ |
| Max. process+thread count | 2787 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/2/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598823501
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 2s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 14s | master passed |
| +1 :green_heart: | checkstyle | 3m 19s | master passed |
| -1 :x: | spotbugs | 2m 1s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-protocol-shaded |
| +1 :green_heart: | checkstyle | 0m 41s | hbase-client: The patch generated 0 new + 414 unchanged - 24 fixed = 414 total (was 438) |
| +1 :green_heart: | checkstyle | 1m 24s | hbase-server: The patch generated 0 new + 655 unchanged - 30 fixed = 655 total (was 685) |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-endpoint |
| +1 :green_heart: | checkstyle | 0m 18s | The patch passed checkstyle in hbase-it |
| +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in hbase-rest |
| +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-examples |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 16m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 3m 50s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 56s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 23s | The patch does not generate ASF License warnings. |
| | | 65m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml cc hbaseprotoc prototool |
| uname | Linux 9ef9a8e056c5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| Max. process+thread count | 93 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598860000
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 8s | master passed |
| +1 :green_heart: | compile | 4m 45s | master passed |
| +1 :green_heart: | shadedjars | 5m 29s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. |
| -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. |
| -0 :warning: | javadoc | 0m 22s | hbase-rest in master failed. |
| -0 :warning: | javadoc | 0m 20s | hbase-examples in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 6s | the patch passed |
| +1 :green_heart: | compile | 4m 46s | the patch passed |
| +1 :green_heart: | javac | 4m 46s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 33s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 22s | hbase-rest in the patch failed. |
| -0 :warning: | javadoc | 0m 18s | hbase-examples in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. |
| -0 :warning: | unit | 99m 44s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 2m 54s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 3m 18s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 42s | hbase-examples in the patch passed. |
| | | 155m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 99123227e423 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/testReport/ |
| Max. process+thread count | 4167 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395118645
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
##########
@@ -82,6 +77,12 @@
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
import org.apache.hbase.thirdparty.com.google.common.base.Throwables;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MultiRowMutationService;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsRequest;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsResponse;
Review comment:
We have multiMutate in this class where we need to make use of MultiRowMutationEndpoint, it is a CPEP so we have to make use of com.google.protobuf instead of the shaded protobuf before this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r393907544
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
##########
@@ -82,6 +77,12 @@
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
import org.apache.hbase.thirdparty.com.google.common.base.Throwables;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MultiRowMutationService;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsRequest;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsResponse;
Review comment:
Was this an oversight on our part? These should have been using the shaded versions all along?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394099926
##########
File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
##########
@@ -77,6 +73,10 @@
import org.slf4j.LoggerFactory;
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+import org.apache.hbase.thirdparty.com.google.protobuf.Service;
+import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException;
/**
* HTable interface to remote tables accessed via REST gateway
Review comment:
This class should be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#issuecomment-598676752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 2s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 24s | master passed |
| +1 :green_heart: | checkstyle | 3m 19s | master passed |
| -1 :x: | spotbugs | 2m 13s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 17s | the patch passed |
| -0 :warning: | checkstyle | 0m 37s | hbase-client: The patch generated 2 new + 414 unchanged - 24 fixed = 416 total (was 438) |
| -0 :warning: | checkstyle | 1m 18s | hbase-server: The patch generated 1 new + 655 unchanged - 30 fixed = 656 total (was 685) |
| -0 :warning: | checkstyle | 0m 17s | hbase-it: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 17m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 3m 58s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 20s | The patch does not generate ASF License warnings. |
| | | 68m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1280 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml cc hbaseprotoc prototool |
| uname | Linux de1346010ef6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1b163d98b9 |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt |
| Max. process+thread count | 93 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r393906696
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/Coprocessor.java
##########
@@ -21,11 +21,11 @@
import java.io.IOException;
import java.util.Collections;
-
-import com.google.protobuf.Service;
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.yetus.audience.InterfaceStability;
+import org.apache.hbase.thirdparty.com.google.protobuf.Service;
+
Review comment:
What about CPEPs? Will clients now need access to the hbase-shaded-protobuf jar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394098204
##########
File path: hbase-endpoint/pom.xml
##########
@@ -47,24 +47,6 @@
<skipAssembly>true</skipAssembly>
</configuration>
</plugin>
- <plugin>
- <groupId>org.xolstice.maven.plugins</groupId>
- <artifactId>protobuf-maven-plugin</artifactId>
- <executions>
- <execution>
- <id>compile-protoc</id>
- <phase>generate-sources</phase>
- <goals>
- <goal>compile</goal>
- </goals>
- <configuration>
- <additionalProtoPathElements>
- <additionalProtoPathElement>${basedir}/../hbase-protocol/src/main/protobuf</additionalProtoPathElement>
- </additionalProtoPathElements>
- </configuration>
- </execution>
- </executions>
- </plugin>
Review comment:
It doesn't have pb local anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services