You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2024/07/31 04:42:16 UTC

[PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

kaka11chen opened a new pull request, #38562:
URL: https://github.com/apache/doris/pull/38562

   ## Proposed changes
   
   Fix allocator.h compiling failed on mac which introduced by #37234.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259636747

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #38562:
URL: https://github.com/apache/doris/pull/38562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259631655

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259631814

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259737638

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168861 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 10dbec4ff810262109c936e1a972fca1963fc1d2, data reload: false
   
   query1	912	373	363	363
   query2	6475	1660	1651	1651
   query3	6664	211	217	211
   query4	20260	17360	17686	17360
   query5	4322	503	505	503
   query6	260	173	166	166
   query7	4618	295	295	295
   query8	254	197	190	190
   query9	8527	2397	2377	2377
   query10	439	294	274	274
   query11	10732	10086	9930	9930
   query12	139	92	86	86
   query13	1650	382	383	382
   query14	9854	7062	6918	6918
   query15	209	168	168	168
   query16	7088	469	461	461
   query17	963	577	559	559
   query18	1911	298	284	284
   query19	196	154	147	147
   query20	93	88	86	86
   query21	207	101	97	97
   query22	4252	3983	4053	3983
   query23	33757	33066	32846	32846
   query24	10327	3134	3066	3066
   query25	705	413	413	413
   query26	1764	158	154	154
   query27	2992	279	279	279
   query28	7032	2009	2005	2005
   query29	1316	428	432	428
   query30	290	152	151	151
   query31	926	754	751	751
   query32	106	54	57	54
   query33	702	323	325	323
   query34	905	468	480	468
   query35	853	741	741	741
   query36	986	872	844	844
   query37	297	81	81	81
   query38	2876	2784	2814	2784
   query39	861	808	801	801
   query40	286	120	129	120
   query41	54	48	49	48
   query42	121	99	101	99
   query43	472	426	436	426
   query44	1212	739	743	739
   query45	213	178	180	178
   query46	1086	814	800	800
   query47	1774	1712	1788	1712
   query48	372	297	293	293
   query49	1210	530	420	420
   query50	889	423	436	423
   query51	6839	6879	6636	6636
   query52	101	93	94	93
   query53	249	181	181	181
   query54	624	449	455	449
   query55	75	74	76	74
   query56	275	270	254	254
   query57	1148	1032	1062	1032
   query58	284	264	281	264
   query59	2516	2487	2460	2460
   query60	314	266	279	266
   query61	98	93	94	93
   query62	912	670	666	666
   query63	215	190	178	178
   query64	5929	1909	1846	1846
   query65	3160	3107	3094	3094
   query66	1437	332	338	332
   query67	15458	14796	14836	14796
   query68	4604	581	565	565
   query69	500	296	298	296
   query70	1128	1077	1065	1065
   query71	465	271	269	269
   query72	7946	2664	2458	2458
   query73	771	331	325	325
   query74	6071	5696	5694	5694
   query75	3945	2747	2713	2713
   query76	3078	1313	1420	1313
   query77	656	303	299	299
   query78	9471	8899	8915	8899
   query79	2119	538	548	538
   query80	1997	519	503	503
   query81	594	225	227	225
   query82	1024	133	128	128
   query83	299	171	172	171
   query84	282	78	78	78
   query85	1364	306	296	296
   query86	417	311	294	294
   query87	3272	3069	3122	3069
   query88	2946	2397	2426	2397
   query89	395	298	292	292
   query90	1954	190	187	187
   query91	124	100	103	100
   query92	72	52	52	52
   query93	1859	622	621	621
   query94	1004	281	287	281
   query95	376	268	269	268
   query96	606	280	280	280
   query97	3227	3059	3050	3050
   query98	212	201	192	192
   query99	1649	1318	1291	1291
   Total cold run time: 268470 ms
   Total hot run time: 168861 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259748024

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259725556

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41964 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 10dbec4ff810262109c936e1a972fca1963fc1d2, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18069	4455	4226	4226
   q2	2447	215	202	202
   q3	11111	1397	1457	1397
   q4	10354	843	861	843
   q5	8667	2953	3046	2953
   q6	229	143	139	139
   q7	1072	617	602	602
   q8	9464	1869	1966	1869
   q9	8550	6611	6621	6611
   q10	8695	3830	3841	3830
   q11	431	253	256	253
   q12	418	225	226	225
   q13	17759	2943	2964	2943
   q14	273	242	249	242
   q15	529	478	488	478
   q16	494	399	401	399
   q17	978	933	927	927
   q18	8043	7279	7262	7262
   q19	1402	1239	1369	1239
   q20	577	331	347	331
   q21	5367	4713	4715	4713
   q22	356	287	280	280
   Total cold run time: 115285 ms
   Total hot run time: 41964 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4063	4016	4010	4010
   q2	334	229	221	221
   q3	2989	3009	3004	3004
   q4	1887	1905	1911	1905
   q5	5293	5229	5254	5229
   q6	213	127	128	127
   q7	2077	1701	1682	1682
   q8	3225	3299	3332	3299
   q9	8363	8357	8357	8357
   q10	3787	3823	3872	3823
   q11	545	467	449	449
   q12	737	572	562	562
   q13	12120	3000	2968	2968
   q14	283	254	254	254
   q15	521	478	475	475
   q16	460	397	393	393
   q17	1740	1684	1690	1684
   q18	7812	7397	7228	7228
   q19	1664	1670	1675	1670
   q20	1992	1773	1744	1744
   q21	5503	5202	5224	5202
   q22	515	458	486	458
   Total cold run time: 66123 ms
   Total hot run time: 54744 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259744491

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.12 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 10dbec4ff810262109c936e1a972fca1963fc1d2, data reload: false
   
   query1	0.04	0.04	0.03
   query2	0.07	0.04	0.04
   query3	0.23	0.05	0.05
   query4	1.67	0.08	0.08
   query5	0.50	0.48	0.48
   query6	1.15	0.72	0.71
   query7	0.02	0.01	0.01
   query8	0.05	0.05	0.04
   query9	0.57	0.50	0.50
   query10	0.57	0.55	0.55
   query11	0.15	0.12	0.12
   query12	0.15	0.12	0.14
   query13	0.62	0.60	0.59
   query14	0.77	0.79	0.79
   query15	0.89	0.86	0.86
   query16	0.35	0.36	0.35
   query17	0.99	0.96	0.99
   query18	0.25	0.21	0.21
   query19	1.86	1.78	1.73
   query20	0.01	0.01	0.02
   query21	15.53	0.78	0.67
   query22	4.01	7.31	1.41
   query23	18.01	1.53	1.40
   query24	2.27	0.22	0.22
   query25	0.18	0.08	0.09
   query26	0.32	0.21	0.21
   query27	0.45	0.23	0.24
   query28	13.16	0.99	0.97
   query29	12.61	3.32	3.28
   query30	0.27	0.06	0.05
   query31	2.86	0.41	0.40
   query32	3.23	0.48	0.49
   query33	2.87	2.97	2.91
   query34	15.46	4.25	4.23
   query35	4.29	4.29	4.31
   query36	0.69	0.48	0.48
   query37	0.20	0.16	0.16
   query38	0.16	0.14	0.14
   query39	0.04	0.03	0.04
   query40	0.15	0.14	0.13
   query41	0.10	0.05	0.04
   query42	0.06	0.05	0.06
   query43	0.05	0.03	0.04
   Total cold run time: 107.88 s
   Total hot run time: 30.12 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](memory) Fix allocator.h compiling failed on mac. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38562:
URL: https://github.com/apache/doris/pull/38562#issuecomment-2259748073

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org