You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stacic <gi...@git.apache.org> on 2014/06/19 22:42:45 UTC
[GitHub] cordova-plugin-globalization pull request: CB-6962 globalization t...
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/12
CB-6962 globalization tests for test-framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-globalization cdvtest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-globalization/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 3057362b293f664c135739d2b94a85fea282e2c4
Author: Staci Cooper <sm...@us.ibm.com>
Date: 2014-06-19T20:41:39Z
CB-6962 globalization tests for test-framework
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-globalization pull request: CB-6962 globalization t...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/12#issuecomment-47383772
Code looks awesome, but adding test code to the plugin is a show-stopper. Going to close PR for now, but please re-open with one of the work-arounds discussed on the ML (put it in a different plugin, or add some tooling)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-globalization pull request: CB-6962 globalization t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---