You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/07/21 20:30:06 UTC

[GitHub] spark pull request #16677: [SPARK-19355][SQL] Use map output statistics to i...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16677#discussion_r204221009
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -204,6 +204,13 @@ object SQLConf {
         .intConf
         .createWithDefault(4)
     
    +  val LIMIT_FLAT_GLOBAL_LIMIT = buildConf("spark.sql.limit.flatGlobalLimit")
    +    .internal()
    +    .doc("During global limit, try to evenly distribute limited rows across data " +
    +      "partitions. If disabled, scanning data partitions sequentially until reaching limit number.")
    +    .booleanConf
    +    .createWithDefault(true)
    --- End diff --
    
    @hvanhovell Should we set it false by default?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org