You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xi...@apache.org on 2026/10/19 06:16:49 UTC
(pinot) branch codex/test-audit-ntile-operand-validation-test created (now 9a482ab559d)
This is an automated email from the ASF dual-hosted git repository.
xiangfu0 pushed a change to branch codex/test-audit-ntile-operand-validation-test
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 9a482ab559d Assert NTILE operand validation in window test
This branch includes the following new commits:
new 9a482ab559d Assert NTILE operand validation in window test
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
(pinot) 01/01: Assert NTILE operand validation in window test
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiangfu0 pushed a commit to branch codex/test-audit-ntile-operand-validation-test
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 9a482ab559d0abe0e0df4f247e476c077f4f6dc5
Author: Xiang Fu <xi...@apache.org>
AuthorDate: Sun Oct 18 23:16:10 2026 -0700
Assert NTILE operand validation in window test
---
.../runtime/operator/WindowAggregateOperatorTest.java | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperatorTest.java b/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperatorTest.java
index 02fa104d657..a6a4913a45a 100644
--- a/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperatorTest.java
+++ b/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperatorTest.java
@@ -18,6 +18,7 @@
*/
package org.apache.pinot.query.runtime.operator;
+import com.google.common.base.Throwables;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
@@ -53,6 +54,7 @@ import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.expectThrows;
public class WindowAggregateOperatorTest {
@@ -258,10 +260,8 @@ public class WindowAggregateOperatorTest {
Integer.MIN_VALUE, Integer.MAX_VALUE, input);
}
- @Test(expectedExceptions = RuntimeException.class, expectedExceptionsMessageRegExp = ".*Failed to instantiate "
- + "WindowFunction for function: NTILE.*")
- public void testShouldThrowOnUnknownRankAggFunction() {
- // TODO: Remove this test when support is added for NTILE function
+ @Test
+ public void testShouldThrowOnNtileWithoutOperand() {
// Given:
DataSchema inputSchema = new DataSchema(new String[]{"unknown"}, new ColumnDataType[]{DOUBLE});
MultiStageOperator input = new BlockListMultiStageOperator.Builder(inputSchema).buildWithEos();
@@ -271,8 +271,12 @@ public class WindowAggregateOperatorTest {
List.of(new RexExpression.FunctionCall(ColumnDataType.INT, SqlKind.NTILE.name(), List.of()));
// When:
- getOperator(inputSchema, resultSchema, keys, List.of(), aggCalls, WindowNode.WindowFrameType.RANGE,
- Integer.MIN_VALUE, Integer.MAX_VALUE, input);
+ RuntimeException exception = expectThrows(RuntimeException.class,
+ () -> getOperator(inputSchema, resultSchema, keys, List.of(), aggCalls, WindowNode.WindowFrameType.RANGE,
+ Integer.MIN_VALUE, Integer.MAX_VALUE, input));
+ Throwable rootCause = Throwables.getRootCause(exception);
+ assertEquals(rootCause.getClass(), IllegalArgumentException.class);
+ assertEquals(rootCause.getMessage(), "NTILE function must have exactly 1 operand");
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org