You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/06/05 16:29:59 UTC

[GitHub] emilianbold commented on a change in pull request #561: Removing GPL licenses from nbbuild/licenses, and a lot of various ref…

emilianbold commented on a change in pull request #561: Removing GPL licenses from nbbuild/licenses, and a lot of various ref…
URL: https://github.com/apache/incubator-netbeans/pull/561#discussion_r193138924
 
 

 ##########
 File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateDependencies.java
 ##########
 @@ -107,7 +107,7 @@ public void setSourceDependencies(boolean sourceDependencies) {
 
                 Map<String, Map<String, Set<String>>> dependenciesDesc = new LinkedHashMap<>();
                 dependenciesDesc.put("Runtime dependencies:", origin2TextsRuntime);
-                if (sourceDependencies) {
+                if (sourceDependencies && /*don't print the compile-time dependencies*/false) {
 
 Review comment:
   > maybe lets wait till the VOTE Emilian started is done
   
   Voting has finished. We are free to merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists