You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Mathias Bogaert (JIRA)" <ji...@apache.org> on 2008/11/21 15:45:36 UTC

[jira] Created: (WW-2880) Use Concurrent API for DispatcherListeners

Use Concurrent API for DispatcherListeners
------------------------------------------

                 Key: WW-2880
                 URL: https://issues.apache.org/struts/browse/WW-2880
             Project: Struts 2
          Issue Type: Improvement
          Components: Dispatch Filter
            Reporter: Mathias Bogaert
             Fix For: 2.0.15
         Attachments: dispatcherlisteners_synch.patch

Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45069#action_45069 ] 

Musachy Barroso commented on WW-2880:
-------------------------------------

I think this can be merged

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Mathias Bogaert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mathias Bogaert updated WW-2880:
--------------------------------

    Attachment: dispatcherlisteners_synch.patch

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.0.15
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes Wannemacher resolved WW-2880.
---------------------------------

    Resolution: Fixed
      Assignee: Wes Wannemacher

committed, thanks for the patch Mathias!

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>            Assignee: Wes Wannemacher
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Musachy Barroso updated WW-2880:
--------------------------------

    Fix Version/s:     (was: 2.0.15)
                   2.1.3

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45050#action_45050 ] 

Wes Wannemacher commented on WW-2880:
-------------------------------------

A little bit of reading, and it appears that this should work fine when retrotranslated. 

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45049#action_45049 ] 

Wes Wannemacher commented on WW-2880:
-------------------------------------

What are the ramifications of applying this patch, if the libraries are then retrotranslated to jdk1.4? The CopyOnWriteArrayList wasn't introduced until 1.5. I like what you're doing, but every time we try to drop support for jdk1.4, there are people who end up needing support.

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45052#action_45052 ] 

Wes Wannemacher commented on WW-2880:
-------------------------------------

Paul, after reading about it on sf, the retrotranslater accounts for use of the concurrency api and adds support for it by using the backport from here - http://backport-jsr166.sourceforge.net/. I don't have any apps that run s2 in jdk1.4, so I can't test it, but I'd like to keep it for 2.1 and hope someone can apply the patch and test it (backported). I am testing it right now to see that showcase, etc. works un-translated, so as long as someone tests with jdk1.4, I think it would be good to go ahead with it.

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45051#action_45051 ] 

Paul Benedict commented on WW-2880:
-----------------------------------

Wes, why not bump this to 2.2? If JDK 1.4 is still targeted unofficially, we shouldn't up the risk factor.

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2880) Use Concurrent API for DispatcherListeners

Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45054#action_45054 ] 

Dave Newton commented on WW-2880:
---------------------------------

AFAIK if you include the backport (concurrency) lib things will work under 1.4. Now that I have a working build box I'll see if I can get a 1.4 version running, but... as per the conversation on dev I'm really not sure we should officially care about 1.4 for 2.1 moving forward.

> Use Concurrent API for DispatcherListeners
> ------------------------------------------
>
>                 Key: WW-2880
>                 URL: https://issues.apache.org/struts/browse/WW-2880
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: dispatcherlisteners_synch.patch
>
>
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.