You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "leesf (via GitHub)" <gi...@apache.org> on 2023/08/18 06:30:16 UTC

[GitHub] [spark] leesf opened a new pull request, #42553: [SPARK-44864] Align streaming statistics link format with other page links

leesf opened a new pull request, #42553:
URL: https://github.com/apache/spark/pull/42553

   
   
   ### What changes were proposed in this pull request?
   Align streaming statistics link format with other page links. Which means change StreamingQueryPage`%s/%s/statistics?id=%s` to `%s/%s/statistics/?id=%s`, this aligns with other page links such as Stages Page `/stages/stage/?id=xxx` , SQL Page `SQL/execution/?id`
   
   
   ### Why are the changes needed?
   Aligns the link format.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Manually tested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-44864] Align streaming statistics link format with other page links [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42553: [SPARK-44864] Align streaming statistics link format with other page links
URL: https://github.com/apache/spark/pull/42553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] leesf commented on pull request #42553: [SPARK-44864] Align streaming statistics link format with other page links

Posted by "leesf (via GitHub)" <gi...@apache.org>.
leesf commented on PR #42553:
URL: https://github.com/apache/spark/pull/42553#issuecomment-1686142418

   > TBH `%s/%s/statistics?id=%s` is more "restful". (And, of course it would be totally restful if it is `%s/%s/statistics/%s`, but we can't make such changes.)
   
   @gengliangwang Thanks for the comment, so for now, do we need to change other page link format to make it more `restful` or align the streaming link with other page link for first stage unify?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on pull request #42553: [SPARK-44864] Align streaming statistics link format with other page links

Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #42553:
URL: https://github.com/apache/spark/pull/42553#issuecomment-1685566875

   TBH `%s/%s/statistics?id=%s` is more "restful".
   (And, of course it would be totally restful if it is `%s/%s/statistics/%s`, but we can't make such changes.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-44864] Align streaming statistics link format with other page links [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42553:
URL: https://github.com/apache/spark/pull/42553#issuecomment-1832904182

   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42553: [SPARK-44864] Align streaming statistics link format with other page links

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42553:
URL: https://github.com/apache/spark/pull/42553#issuecomment-1685526203

   cc @gengliangwang and @sarutak FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-44864] Align streaming statistics link format with other page links [spark]

Posted by "leesf (via GitHub)" <gi...@apache.org>.
leesf commented on PR #42553:
URL: https://github.com/apache/spark/pull/42553#issuecomment-1832933768

   @gengliangwang would you please take a look? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org