You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/08 01:11:11 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #7111: Trigger rollover when meeting maxLedgerRolloverTimeMinutes

sijie commented on a change in pull request #7111:
URL: https://github.com/apache/pulsar/pull/7111#discussion_r436420743



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -277,6 +278,8 @@ public BrokerService(PulsarService pulsar) throws Exception {
             Executors.newSingleThreadScheduledExecutor(new DefaultThreadFactory("pulsar-publish-buffer-monitor"));
         this.consumedLedgersMonitor = Executors
                 .newSingleThreadScheduledExecutor(new DefaultThreadFactory("consumed-Ledgers-monitor"));
+        this.ledgerFullMonitor =

Review comment:
       +1 @wuzhanpeng can we re-use an existing executor? Otherwise, we end up creating a lot of executors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org