You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/02/15 02:41:02 UTC
Re: Review Request 17376: PIG-3000 Nested Foreach optimization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17376/
-----------------------------------------------------------
(Updated Feb. 15, 2014, 1:41 a.m.)
Review request for pig and Rohini Palaniswamy.
Bugs: PIG-3000
https://issues.apache.org/jira/browse/PIG-3000
Repository: pig-git
Description
-------
See JIRA.
Diffs
-----
src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java 387d12f
src/org/apache/pig/newplan/logical/optimizer/LogicalPlanOptimizer.java 45b7418
src/org/apache/pig/newplan/logical/rules/NestedForEachUserFunc.java PRE-CREATION
Diff: https://reviews.apache.org/r/17376/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 17376: PIG-3000 Nested Foreach optimization
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17376/
-----------------------------------------------------------
(Updated March 30, 2014, 2:25 a.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
working patch for single col manipulation within nested foreach. unit tests for more comprehensive cases already attached to JIRA and can be patched for as a follow-up JIRA.
Changes in HExecutionEngine and LogicalPlanOptimizer are trivial to enable this new rule and same as in diff rev 1.
Bugs: PIG-3000
https://issues.apache.org/jira/browse/PIG-3000
Repository: pig-git
Description
-------
See JIRA.
Diffs (updated)
-----
src/org/apache/pig/newplan/logical/rules/NestedForEachUserFunc.java e69de29
test/org/apache/pig/test/TestNestedForEachUserFunc.java e69de29
Diff: https://reviews.apache.org/r/17376/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 17376: PIG-3000 Nested Foreach optimization
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17376/
-----------------------------------------------------------
(Updated March 28, 2014, 4:53 p.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
Working code for simple case - nested foreach userfunc loading single argument and generate operating on same argument.
commented out code is to make it work for complex cases
1. multiple arguments
2. userfunc having a subset of generate arguments - how to pass through from initial load to initial foreach
Bugs: PIG-3000
https://issues.apache.org/jira/browse/PIG-3000
Repository: pig-git
Description
-------
See JIRA.
Diffs (updated)
-----
src/org/apache/pig/newplan/logical/rules/NestedForEachUserFunc.java e69de29
Diff: https://reviews.apache.org/r/17376/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 17376: PIG-3000 Nested Foreach optimization
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17376/
-----------------------------------------------------------
(Updated March 26, 2014, 1:27 a.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
got past the uid -1 error, but once physical plan is constructed, tuples are not getting iterated through the UserFunc.
Bugs: PIG-3000
https://issues.apache.org/jira/browse/PIG-3000
Repository: pig-git
Description
-------
See JIRA.
Diffs (updated)
-----
src/org/apache/pig/newplan/logical/rules/NestedForEachUserFunc.java e69de29
Diff: https://reviews.apache.org/r/17376/diff/
Testing
-------
Thanks,
Mona Chitnis