You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Haejoon Lee (Jira)" <ji...@apache.org> on 2022/01/07 02:45:00 UTC

[jira] [Created] (SPARK-37835) Fix the comments on SQLQueryTestSuite.scala to generate the golden files more gracefully

Haejoon Lee created SPARK-37835:
-----------------------------------

             Summary: Fix the comments on SQLQueryTestSuite.scala to generate the golden files more gracefully
                 Key: SPARK-37835
                 URL: https://issues.apache.org/jira/browse/SPARK-37835
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 3.3.0
            Reporter: Haejoon Lee


Currently, the comments on `SQLQueryTestSuite.scala` says:
{code:java}
 * To re-generate golden files for entire suite, run:
 * {{{
 *   SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite" 
 * }}} {code}
But this comment modifies the "-- Automatically generated by SQLQueryTestSuite" part with different test suites names for whole golden files, although the contents of golden files is not modified.

So, we'd better to recommend to use `org.apache.spark.sql.SQLQueryTestSuite` instead of `*SQLQueryTestSuite`.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org