You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by as...@apache.org on 2020/06/29 14:20:39 UTC
[mesos] branch 1.8.x updated: Fixed wclayer download in Windows
build with CMake 3.17+
This is an automated email from the ASF dual-hosted git repository.
asekretenko pushed a commit to branch 1.8.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/1.8.x by this push:
new b46fd1a Fixed wclayer download in Windows build with CMake 3.17+
b46fd1a is described below
commit b46fd1aea2801bc21eff974d03295b18d6915df3
Author: Eduard Staniloiu <ed...@gmail.com>
AuthorDate: Tue Jun 23 16:02:04 2020 +0300
Fixed wclayer download in Windows build with CMake 3.17+
This fixes incorrect setting `DOWNLOAD_NO_EXTRACT FALSE` in the
`wclayer` ExternalProject target, which breaks Windows build starting
from CMake 3.17+
The bug has apparently been triggered by the fix in the ExternalProject
module that makes `DOWNLOAD_NO_EXTRACT OFF`/`DOWNLOAD_NO_EXTRACT FALSE`
work correctly:
https://github.com/Kitware/CMake/commit/2c4bb705e842db66904df5014a5755b57ac51b72
This closes #366
---
3rdparty/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index 53396fb..4c60e23 100644
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -888,7 +888,7 @@ if (WIN32)
CONFIGURE_COMMAND ${CMAKE_NOOP}
BUILD_COMMAND ${CMAKE_NOOP}
INSTALL_COMMAND ${WCLAYER_INSTALL_CMD}
- DOWNLOAD_NO_EXTRACT FALSE
+ DOWNLOAD_NO_EXTRACT TRUE
URL ${WCLAYER_URL})
endif ()