[GitHub] [accumulo] EdColeman commented on a change in pull request #1667: Fix #1663 - Missing metrics files running CI tests

[GitBox <gi...@apache.org>]

EdColeman commented on a change in pull request #1667:
URL: https://github.com/apache/accumulo/pull/1667#discussion_r463390971



##########
File path: pom.xml
##########
@@ -658,6 +658,9 @@
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-jar-plugin</artifactId>
           <configuration>
+            <excludes>
+              <exclude>**/hadoop-metrics2-accumulo.properties</exclude>
+            </excludes>

Review comment:
       Should I add a complete maven-jar-plugin to the test module pom?  I looked there but I did not see one configured. I thought about it, but was unsure if a new plugin configuration or promoting it to the parent would be preferred.  
   
   Having it in the parent does have a side benefit that if any module ends up needing a metrics file for testing it would be excluded by default.
   
   It's your call as to the preferred approach.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org