You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrew Bayer (JIRA)" <ji...@apache.org> on 2012/08/27 20:14:08 UTC
[jira] [Created] (WHIRR-646) Integration tests should have failsafe
timeouts
Andrew Bayer created WHIRR-646:
----------------------------------
Summary: Integration tests should have failsafe timeouts
Key: WHIRR-646
URL: https://issues.apache.org/jira/browse/WHIRR-646
Project: Whirr
Issue Type: Bug
Components: build
Affects Versions: 0.8.0
Reporter: Andrew Bayer
Assignee: Andrew Bayer
Fix For: 0.8.1, 0.9.0
Currently, we're not checking for timeouts on integration test execution, meaning that if one test hangs, the whole build is borked. We should fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (WHIRR-646) Integration tests should have
failsafe timeouts
Posted by Andrei Savu <sa...@gmail.com>.
Fyi we also have some timeouts on individual tests.
+1 for adding a timeout for the child process - sometimes the setUp method
can block.
On Aug 27, 2012 9:20 PM, "Andrew Bayer (JIRA)" <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/WHIRR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Andrew Bayer updated WHIRR-646:
> -------------------------------
>
> Attachment: WHIRR-646.patch
>
> This patch adds a 60 minute timeout for forked integration tests - we're
> using the default forkMode of "once", so this timeout would be for all the
> tests in a given module. I can't see anything needing close to 60 minutes
> for a single module's integration tests barring something going wrong (in
> which case we *want* it to be killed by failsafe here anyway), so I think
> this is good. Also bumped the surefire and failsafe version to the latest,
> 2.12.
>
> > Integration tests should have failsafe timeouts
> > -----------------------------------------------
> >
> > Key: WHIRR-646
> > URL: https://issues.apache.org/jira/browse/WHIRR-646
> > Project: Whirr
> > Issue Type: Bug
> > Components: build
> > Affects Versions: 0.8.0
> > Reporter: Andrew Bayer
> > Assignee: Andrew Bayer
> > Fix For: 0.8.1, 0.9.0
> >
> > Attachments: WHIRR-646.patch
> >
> >
> > Currently, we're not checking for timeouts on integration test
> execution, meaning that if one test hangs, the whole build is borked. We
> should fix that.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
[jira] [Commented] (WHIRR-646) Integration tests should have
failsafe timeouts
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458610#comment-13458610 ]
Andrei Savu commented on WHIRR-646:
-----------------------------------
+1
> Integration tests should have failsafe timeouts
> -----------------------------------------------
>
> Key: WHIRR-646
> URL: https://issues.apache.org/jira/browse/WHIRR-646
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Andrew Bayer
> Assignee: Andrew Bayer
> Fix For: 0.8.1, 0.9.0
>
> Attachments: WHIRR-646.patch
>
>
> Currently, we're not checking for timeouts on integration test execution, meaning that if one test hangs, the whole build is borked. We should fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-646) Integration tests should have failsafe
timeouts
Posted by "Andrew Bayer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Bayer updated WHIRR-646:
-------------------------------
Attachment: WHIRR-646.patch
This patch adds a 60 minute timeout for forked integration tests - we're using the default forkMode of "once", so this timeout would be for all the tests in a given module. I can't see anything needing close to 60 minutes for a single module's integration tests barring something going wrong (in which case we *want* it to be killed by failsafe here anyway), so I think this is good. Also bumped the surefire and failsafe version to the latest, 2.12.
> Integration tests should have failsafe timeouts
> -----------------------------------------------
>
> Key: WHIRR-646
> URL: https://issues.apache.org/jira/browse/WHIRR-646
> Project: Whirr
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Andrew Bayer
> Assignee: Andrew Bayer
> Fix For: 0.8.1, 0.9.0
>
> Attachments: WHIRR-646.patch
>
>
> Currently, we're not checking for timeouts on integration test execution, meaning that if one test hangs, the whole build is borked. We should fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira