You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Gordon King <no...@github.com.INVALID> on 2021/08/17 05:30:25 UTC

[apache/incubator-teaclave] Fix dependent PkgConfig missing (#545)

## Description
The cmake `pkg_check_modules` relies on `PkgConfig` to check the version of `libsgx_urts`. 
It just reported that the `Intel SGX SDK (version 2.12.100.3) is not found or version not matched.` if `PkgConfig` not been correctly installed. so it is necessary to check and prompt user the the missing package right before `libsgx_urts` check.

Fixes ##544

## Type of change (select or add applied and delete the others)

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates

## How has this been tested?

## Checklist

- [X] Fork the repo and create your branch from `master`.
- [ ] If you&#39;ve added code that should be tested, add tests.
- [ ] If you&#39;ve changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/545

-- Commit Summary --

  * Fix dependent PkgConfig missing

-- File Changes --

    M CMakeLists.txt (4)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/545.patch
https://github.com/apache/incubator-teaclave/pull/545.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/545

Re: [apache/incubator-teaclave] Fix dependent PkgConfig missing (#545)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Merged #545 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/545#event-5170132208