You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/04 03:07:39 UTC

[GitHub] [hudi] codope commented on pull request #3360: [HUDI-2243] Support Time Travel Query For Hoodie Table

codope commented on pull request #3360:
URL: https://github.com/apache/hudi/pull/3360#issuecomment-892324921


   > > @pengzhiwei2018 Thanks for this. Maybe we could have couple of follow on tasks.
   > > 
   > > 1. Allow user to specify `as.of.instant` in `YYYY-MM-DD` to `YYYY-MM-DD hh:mm:ss` formts.
   > > 2. Support this with SQL dml as well, e.g. `select a,b,c from hudi_table AS OF 20210728141108 `. This would really help useers to rollback using CTAS directly. What do you think?
   > 
   > Both Agreed! I will submit a PR to support time travel query for spark sql after #3277 has merged as we need do some sql extension for `hudi-spark` module based on that PR which has did a lot of basic work.
   > For question 1, This PR has supported now!
   
   @pengzhiwei2018 Thanks for quickly adding the first suggestion. This diff looks good to me. Can you resolve the conflicts and then we can land it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org