You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/06/27 21:16:07 UTC

svn commit: r1140277 - /james/server/trunk/protocols-library/src/main/java/org/apache/james/protocols/lib/POP3BeforeSMTPHelper.java

Author: norman
Date: Mon Jun 27 19:16:06 2011
New Revision: 1140277

URL: http://svn.apache.org/viewvc?rev=1140277&view=rev
Log:
Use generics

Modified:
    james/server/trunk/protocols-library/src/main/java/org/apache/james/protocols/lib/POP3BeforeSMTPHelper.java

Modified: james/server/trunk/protocols-library/src/main/java/org/apache/james/protocols/lib/POP3BeforeSMTPHelper.java
URL: http://svn.apache.org/viewvc/james/server/trunk/protocols-library/src/main/java/org/apache/james/protocols/lib/POP3BeforeSMTPHelper.java?rev=1140277&r1=1140276&r2=1140277&view=diff
==============================================================================
--- james/server/trunk/protocols-library/src/main/java/org/apache/james/protocols/lib/POP3BeforeSMTPHelper.java (original)
+++ james/server/trunk/protocols-library/src/main/java/org/apache/james/protocols/lib/POP3BeforeSMTPHelper.java Mon Jun 27 19:16:06 2011
@@ -36,7 +36,7 @@ public class POP3BeforeSMTPHelper {
     /**
      * The map in which the ipAddresses and timestamp stored
      */
-    public static Map ipMap = Collections.synchronizedMap(new HashMap());
+    public static Map<String, Long> ipMap = Collections.synchronizedMap(new HashMap<String, Long>());
 
     /**
      * Default expire time in ms (1 hour)
@@ -61,7 +61,7 @@ public class POP3BeforeSMTPHelper {
      *            The ipAddress
      */
     public static void addIPAddress(String ipAddress) {
-        ipMap.put(ipAddress, Long.toString(System.currentTimeMillis()));
+        ipMap.put(ipAddress, System.currentTimeMillis());
     }
 
     /**
@@ -81,12 +81,12 @@ public class POP3BeforeSMTPHelper {
      */
     public static void removeExpiredIP(long clearTime) {
         synchronized (ipMap) {
-            Iterator storedIP = ipMap.keySet().iterator();
+            Iterator<String> storedIP = ipMap.keySet().iterator();
             long currTime = System.currentTimeMillis();
 
             while (storedIP.hasNext()) {
                 String key = storedIP.next().toString();
-                long storedTime = Long.parseLong((String) ipMap.get(key));
+                long storedTime = ipMap.get(key);
 
                 // remove the ip from the map when it is expired
                 if ((currTime - clearTime) > storedTime) {



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org