[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9408: Cleanup: records.config cleanup for references and comments.

["cmcfarlen (via GitHub)" <gi...@apache.org>]

cmcfarlen commented on code in PR #9408:
URL: https://github.com/apache/trafficserver/pull/9408#discussion_r1106302818


##########
ci/jenkins/bin/cache-tests.sh:
##########
@@ -58,9 +57,10 @@ ${PREFIX}/bin/trafficserver stop
 
 # Now run it again, maybe, with the tweaked configs
 if [ "" != "$TWEAK" ]; then
-#    echo "CONFIG proxy.config.http.cache.required_headers INT 1" >> $RECORDS
-    echo "CONFIG proxy.config.http.negative_caching_enabled INT 1" >> $RECORDS
     ${PREFIX}/bin/trafficserver start
+    sleep 5
+    ${PREFIX}/bin/traffic_ctl config set proxy.config.http.negative_caching_enabled 1
+    sleep 5

Review Comment:
   This sleep here isn't very exciting.  If we installed `yq` to the ci image you could do: `yq -i '.ts.http.negative_caching_enabled=1' $RECORDS` before starting traffic server. Or if traffic_ctl could do the out-of-band edit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org