You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Cahill <dc...@midokura.com> on 2013/05/20 10:09:19 UTC
Review Request: Add package declaration to MidoNetElementTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11232/
-----------------------------------------------------------
Review request for cloudstack and Pranav Saxena.
Description
-------
>From Mike Tutkowski on-list [1] :
"If someone has committer privileges, perhaps you could provide
MidoNetElementTest a package declaration. I notice it's coming up with a
warning because of that."
I couldn't find the warning, but the change makes sense.
http://markmail.org/message/s2z42w5tfl5x7h6c
Diffs
-----
plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java baf99b9
Diff: https://reviews.apache.org/r/11232/diff/
Testing
-------
Change affects only a test file; ran test suite before and after.
Thanks,
Dave Cahill
Re: Review Request: Add package declaration to MidoNetElementTest
Posted by Mike Tutkowski <mi...@solidfire.com>.
You know, I probably should have mentioned where I was seeing the warning.
:) It was in Eclipse.
On Mon, May 20, 2013 at 11:58 AM, Chip Childers <ch...@apache.org>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11232/#review20773
> -----------------------------------------------------------
>
> Ship it!
>
>
> committed to master
>
> - Chip Childers
>
>
> On May 20, 2013, 8:09 a.m., Dave Cahill wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11232/
> > -----------------------------------------------------------
> >
> > (Updated May 20, 2013, 8:09 a.m.)
> >
> >
> > Review request for cloudstack and Pranav Saxena.
> >
> >
> > Description
> > -------
> >
> > From Mike Tutkowski on-list [1] :
> > "If someone has committer privileges, perhaps you could provide
> > MidoNetElementTest a package declaration. I notice it's coming up with a
> > warning because of that."
> >
> > I couldn't find the warning, but the change makes sense.
> >
> > http://markmail.org/message/s2z42w5tfl5x7h6c
> >
> >
> > Diffs
> > -----
> >
> >
> plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java
> baf99b9
> >
> > Diff: https://reviews.apache.org/r/11232/diff/
> >
> >
> > Testing
> > -------
> >
> > Change affects only a test file; ran test suite before and after.
> >
> >
> > Thanks,
> >
> > Dave Cahill
> >
> >
>
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
Re: Review Request: Add package declaration to MidoNetElementTest
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11232/#review20773
-----------------------------------------------------------
Ship it!
committed to master
- Chip Childers
On May 20, 2013, 8:09 a.m., Dave Cahill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11232/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> From Mike Tutkowski on-list [1] :
> "If someone has committer privileges, perhaps you could provide
> MidoNetElementTest a package declaration. I notice it's coming up with a
> warning because of that."
>
> I couldn't find the warning, but the change makes sense.
>
> http://markmail.org/message/s2z42w5tfl5x7h6c
>
>
> Diffs
> -----
>
> plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java baf99b9
>
> Diff: https://reviews.apache.org/r/11232/diff/
>
>
> Testing
> -------
>
> Change affects only a test file; ran test suite before and after.
>
>
> Thanks,
>
> Dave Cahill
>
>