[GitHub] [lucene] ChristophKaser commented on a change in pull request #124: LUCENE-9951: Add InfoStream to ReplicationService

[GitBox <gi...@apache.org>]

ChristophKaser commented on a change in pull request #124:
URL: https://github.com/apache/lucene/pull/124#discussion_r625635261



##########
File path: lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java
##########
@@ -183,6 +203,17 @@ public void perform(HttpServletRequest req, HttpServletResponse resp)
           break;
       }
     } catch (Exception e) {
+      if (infoStream.isEnabled(INFO_STREAM_COMPONENT)) {
+        final StringWriter sw = new StringWriter();
+        sw.append("an error occurred during replication service call (");
+        sw.append(req.getRequestURI());
+        if (req.getQueryString() != null) {
+          sw.append('?').append(req.getQueryString());
+        }
+        sw.append("): ");
+        e.printStackTrace(new PrintWriter(sw));

Review comment:
       There is no sensitive information in a replication request
   @muse-dev ignore




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org