You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "bknbkn (via GitHub)" <gi...@apache.org> on 2023/10/18 13:07:39 UTC
[PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
bknbkn opened a new pull request, #8868:
URL: https://github.com/apache/iceberg/pull/8868
This change will make deletedPaths call 'add' function only if it not contains file path, thus avoiding the unnecessary caused by 'add' function calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
Posted by "bknbkn (via GitHub)" <gi...@apache.org>.
bknbkn commented on PR #8868:
URL: https://github.com/apache/iceberg/pull/8868#issuecomment-1771963125
> Not sure I understand this change. Seems like you are removing an optimization to avoid re computing whether a path is deleted if we already determined it is deleted?
In the original code, the `deletePath.add()` function is called regardless of whether the path is already in the `deletePath` set. I think it only needs to be called when the path is not in the `deletePath` set, if the path is already in the `deletePath` set, calling the `deletePath.add()` function will add nothing and is also unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #8868:
URL: https://github.com/apache/iceberg/pull/8868#issuecomment-1771557957
Not sure I understand this change. Seems like you are removing an optimization to avoid re computing whether a path is deleted if we already determined it is deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #8868:
URL: https://github.com/apache/iceberg/pull/8868#issuecomment-1771989413
What about the check on 422?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
Posted by "bknbkn (via GitHub)" <gi...@apache.org>.
bknbkn commented on PR #8868:
URL: https://github.com/apache/iceberg/pull/8868#issuecomment-1769775332
cc @RussellSpitzer. @rdblue, may I request your assistance in enabling workflows approval? Thanks for your time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
Posted by "bknbkn (via GitHub)" <gi...@apache.org>.
bknbkn commented on PR #8868:
URL: https://github.com/apache/iceberg/pull/8868#issuecomment-1772037756
> What about the check on 422?
sorry, I made a mistake in the previous comment. The change being discussed pertains to the `deletedPath` and only affects the code starting from line 433. It has been corrected now. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Reduce unnecessary add operations in deletedPaths set [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #8868:
URL: https://github.com/apache/iceberg/pull/8868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org