You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "John Sichi (JIRA)" <ji...@apache.org> on 2010/02/03 21:23:27 UTC

[jira] Created: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
--------------------------------------------------------------------------

                 Key: HIVE-1129
                 URL: https://issues.apache.org/jira/browse/HIVE-1129
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.6.0
            Reporter: John Sichi
             Fix For: 0.6.0


I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.

So, I added the following to my environment:

export HADOOP_OPTS="-ea -esa"

This worked, and allowed me to see assertion failures when executing via CLI.

But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:

    // Turn on speculative execution for reducers
    HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
        HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));

The assertion says it should be using getBoolVar/setBoolVar instead.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi reassigned HIVE-1129:
--------------------------------

    Assignee: John Sichi

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829757#action_12829757 ] 

John Sichi commented on HIVE-1129:
----------------------------------

In the spirit of keeping patch transactions small and focused, maybe it would be better to commit this patch as is and assign me a separate JIRA for adding and using the setter methods?  The reason I say this is that my patch followed the existing pattern here in the same file:

    if(work.getMinSplitSize() != null) {
      job.setInt(HiveConf.ConfVars.MAPREDMINSPLITSIZE.varname, 
         work.getMinSplitSize().intValue());
    }

So that code will need to be changed too as part of consistently using the new setters, and that change is unrelated to my fix for the existing bug with assertions.


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1129:
-----------------------------

    Attachment: HIVE-1129.1.patch

Here's a patch for getting/setting the variables in such a way that the assertions are not triggered.


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829234#action_12829234 ] 

John Sichi commented on HIVE-1129:
----------------------------------

Here's the assertion stack:

    [junit] Exception in thread "main" java.lang.AssertionError
    [junit] 	at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:292)
    [junit] 	at org.apache.hadoop.hive.ql.exec.ExecDriver.execute(ExecDriver.java:569)
    [junit] 	at org.apache.hadoop.hive.ql.exec.ExecDriver.main(ExecDriver.java:946)


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>             Fix For: 0.6.0
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829474#action_12829474 ] 

Zheng Shao commented on HIVE-1129:
----------------------------------

Hi John, can you add the setBoolVar() function to HiveConf class just like the getBoolVar()? That makes the code easier to read and also more consistent.


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1129:
-----------------------------

    Status: Open  (was: Patch Available)

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829235#action_12829235 ] 

John Sichi commented on HIVE-1129:
----------------------------------

Also, I don't really understand what this code is doing.  Why is doing setVar using the current result of getVar?  Doesn't that mean it has no effect?


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>             Fix For: 0.6.0
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829249#action_12829249 ] 

John Sichi commented on HIVE-1129:
----------------------------------

Haha, you're right, I should get my eyes checked.


> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>             Fix For: 0.6.0
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1129:
-----------------------------

    Affects Version/s:     (was: 0.6.0)
                       0.5.0
               Status: Patch Available  (was: Open)

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830386#action_12830386 ] 

Zheng Shao commented on HIVE-1129:
----------------------------------

+1. That makes sense to me.
Please open a follow-up as an "improvement".

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1129:
-----------------------------

      Resolution: Fixed
    Release Note: HIVE-1129. Fix assertion in ExecDriver.execute. (John Sichi via zshao)
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed. Thanks John!

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1129:
-----------------------------

    Status: Patch Available  (was: Open)

Resubmitting patch as is.  If you agree with me, I'll create a followup for adding the setters; otherwise, cancel it and I'll combine the two changes.

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829322#action_12829322 ] 

Namit Jain commented on HIVE-1129:
----------------------------------

A parameter exists for enabling speculative execution for reducers in hive - the reason we added it about a month back was that we 
wanted to test it easily -- there were some bugs in speculative execution for reducers in hadoop 17, which is why we had disabled it.
Now that those bugs have been solved, we wanted to test it gradually.

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>             Fix For: 0.6.0
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1129) Fix Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1129:
---------------------------------

    Release Note:   (was: HIVE-1129. Fix assertion in ExecDriver.execute. (John Sichi via zshao))
         Summary: Fix Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS  (was: Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS)

> Fix Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1129.1.patch
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1129) Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829244#action_12829244 ] 

Paul Yang commented on HIVE-1129:
---------------------------------

Aren't those two different variables - getVar is accessing HIVESPECULATIVEEXECREDUCERS, while the setVar is setting HADOOPSPECULATIVEEXECREDUCERS.

> Assertion in ExecDriver.execute when assertions are enabled in HADOOP_OPTS
> --------------------------------------------------------------------------
>
>                 Key: HIVE-1129
>                 URL: https://issues.apache.org/jira/browse/HIVE-1129
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>             Fix For: 0.6.0
>
>
> I noticed that when running hive CLI, assertions are not enabled, which was causing me some confusion when debugging an issue.
> So, I added the following to my environment:
> export HADOOP_OPTS="-ea -esa"
> This worked, and allowed me to see assertion failures when executing via CLI.
> But then I tried to run a test, and got an assertion failure from the following code in ExecDriver.execute:
>     // Turn on speculative execution for reducers
>     HiveConf.setVar(job, HiveConf.ConfVars.HADOOPSPECULATIVEEXECREDUCERS,
>         HiveConf.getVar(job, HiveConf.ConfVars.HIVESPECULATIVEEXECREDUCERS));
> The assertion says it should be using getBoolVar/setBoolVar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.