You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/23 15:30:03 UTC

[GitHub] [incubator-superset] kkucharc commented on a change in pull request #11407: fix: added meaningful exception for loading births error

kkucharc commented on a change in pull request #11407:
URL: https://github.com/apache/incubator-superset/pull/11407#discussion_r510966235



##########
File path: superset/examples/birth_names.py
##########
@@ -41,6 +41,12 @@
 )
 
 admin = security_manager.find_user("admin")
+if admin is None:
+    raise Exception(

Review comment:
       Great I will. Thanks for suggestion :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org