You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/03/26 08:41:21 UTC
[GitHub] [incubator-paimon] TyrantLucifer opened a new pull request, #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
TyrantLucifer opened a new pull request, #719:
URL: https://github.com/apache/incubator-paimon/pull/719
Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
sub-task of #639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer closed pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
URL: https://github.com/apache/incubator-paimon/pull/719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer closed pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
URL: https://github.com/apache/incubator-paimon/pull/719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer closed pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
URL: https://github.com/apache/incubator-paimon/pull/719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer commented on a diff in pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719#discussion_r1148741069
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/CommitterOperatorTest.java:
##########
@@ -246,7 +256,7 @@ private OneInputStreamOperatorTestHarness<Committable, Committable> createLossyT
new CommitterOperator(
true,
initialCommitUser,
- user -> new StoreCommitter(table.newCommit(user)),
+ user -> new StoreCommitter(table.newStreamWriteBuilder().newCommit()),
Review Comment:
Thank you for you reply, I will fix this problem later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] tsreaper commented on a diff in pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "tsreaper (via GitHub)" <gi...@apache.org>.
tsreaper commented on code in PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719#discussion_r1148737481
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/CommitterOperatorTest.java:
##########
@@ -246,7 +256,7 @@ private OneInputStreamOperatorTestHarness<Committable, Committable> createLossyT
new CommitterOperator(
true,
initialCommitUser,
- user -> new StoreCommitter(table.newCommit(user)),
+ user -> new StoreCommitter(table.newStreamWriteBuilder().newCommit()),
Review Comment:
You forgot `withCommitUser`. I'm thinking if we need to force users to specify a `commitUser` when using `StreamWriteBuilder`, instead of generating a random UUID for them. @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer commented on pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719#issuecomment-1509484350
@tsreaper @JingsongLi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] TyrantLucifer commented on pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719#issuecomment-1515626638
> It seems that test failed?
Could you please help me restart the failed task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #719: [flink] Use new ReadBuilder and WriteBuilder API in tests of paimon-flink module
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719#issuecomment-1515625243
It seems that test failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org