You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/04 19:26:17 UTC
[GitHub] [beam] robertwb opened a new pull request, #23985: Support dynamic sharding in the worker.
robertwb opened a new pull request, #23985:
URL: https://github.com/apache/beam/pull/23985
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb merged PR #23985:
URL: https://github.com/apache/beam/pull/23985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1309497998
Irrelevent timer test timeouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304337255
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304503025
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304325626
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304418509
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304413297
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304361165
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304493251
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304397336
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304369949
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304403717
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304544254
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304090503
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304540127
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304442002
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304458497
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304522425
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304848950
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304427410
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304597300
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304383325
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304313232
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304590635
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304423259
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23985:
URL: https://github.com/apache/beam/pull/23985#discussion_r1015929569
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py:
##########
@@ -1150,7 +1181,8 @@ class BundleManager(object):
def __init__(self,
bundle_context_manager, # type: execution.BundleContextManager
progress_frequency=None, # type: Optional[float]
- cache_token_generator=FnApiRunner.get_cache_token_generator()
+ cache_token_generator=FnApiRunner.get_cache_token_generator(),
+ split_managers=(),
Review Comment:
```suggestion
split_managers=()
```
nit
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py:
##########
@@ -2110,6 +2111,30 @@ def process(
if expected_groups:
assert_that(grouped, equal_to(expected_groups), label='CheckGrouped')
+ def test_time_based_split_manager(self):
+
+ elements = list(range(100))
+
+ class BundleCountingDoFn(beam.DoFn):
+ def process(self, element) -> Iterator[object]:
+ time.sleep(0.001)
+ yield element
+
+ def finish_bundle(self):
+ yield window.GlobalWindows.windowed_value('endOfBundle')
+
+ with self.create_pipeline() as p:
+ p._options.view_as(DirectOptions).test_splits = {
+ 'SplitMarker': {
+ 'timings': [0, .05], 'fractions': [0.5, 0.5]
+ }
+ }
+ assert_that(
+ p
+ | beam.Create(elements)
+ | 'SplitMarker' >> beam.ParDo(BundleCountingDoFn()),
+ equal_to(elements + ['endOfBundle'] * 2))
Review Comment:
Since we have 2 splits, shouldn't we be anticipating 3 endOfBundle calls?
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py:
##########
@@ -2110,6 +2111,30 @@ def process(
if expected_groups:
assert_that(grouped, equal_to(expected_groups), label='CheckGrouped')
+ def test_time_based_split_manager(self):
+
+ elements = list(range(100))
+
+ class BundleCountingDoFn(beam.DoFn):
+ def process(self, element) -> Iterator[object]:
+ time.sleep(0.001)
+ yield element
+
+ def finish_bundle(self):
+ yield window.GlobalWindows.windowed_value('endOfBundle')
+
+ with self.create_pipeline() as p:
+ p._options.view_as(DirectOptions).test_splits = {
+ 'SplitMarker': {
+ 'timings': [0, .05], 'fractions': [0.5, 0.5]
+ }
+ }
+ assert_that(
+ p
+ | beam.Create(elements)
+ | 'SplitMarker' >> beam.ParDo(BundleCountingDoFn()),
+ equal_to(elements + ['endOfBundle'] * 2))
Review Comment:
I think you answer this below:
```
// More than one "endOfBundle" output because we split.
// (We in fact should have split multiple times, but all the
// remainders get concatenated into the second bundle.
// Importantly, however, we verify that regardless of where the
// splits occurred (if you print them, they're in an interesting
// order), all elements are accounted for.)
```
Though I'm not sure why they get concatenated. Regardless, dropping a similar comment here would be helpful
##########
sdks/typescript/src/apache_beam/worker/operators.ts:
##########
@@ -234,6 +257,46 @@ class DataSourceOperator implements IOperator {
throw Error("Data should not come in via process.");
}
+ split(
+ desiredSplit: fnApi.ProcessBundleSplitRequest_DesiredSplit
+ ): fnApi.ProcessBundleSplitResponse_ChannelSplit | undefined {
+ if (!this.started) {
+ return undefined;
+ }
+ const end =
+ this.lastToProcessElement < Infinity
+ ? this.lastToProcessElement
+ : Number(desiredSplit.estimatedInputElements) - 1;
+ console.log(this.lastToProcessElement, this.lastProcessedElement, end);
+ if (this.lastProcessedElement >= end) {
+ return undefined;
+ }
+ var targetLastToProcessElement = Math.floor(
+ this.lastProcessedElement +
+ (end - this.lastProcessedElement) * desiredSplit.fractionOfRemainder
+ );
+ if (desiredSplit.allowedSplitPoints.length) {
+ targetLastToProcessElement =
+ Math.min(
+ ...Array.from(desiredSplit.allowedSplitPoints)
+ .filter((index) => index >= targetLastToProcessElement + 1)
Review Comment:
```suggestion
.filter((allowedSplitPoint) => allowedSplitPoint > targetLastToProcessElement)
```
Optional: I think this can be simplified + naming threw me off here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304295991
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304608311
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304352958
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304407780
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304498560
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304558105
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #23985:
URL: https://github.com/apache/beam/pull/23985#discussion_r1015988455
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py:
##########
@@ -2110,6 +2111,30 @@ def process(
if expected_groups:
assert_that(grouped, equal_to(expected_groups), label='CheckGrouped')
+ def test_time_based_split_manager(self):
+
+ elements = list(range(100))
+
+ class BundleCountingDoFn(beam.DoFn):
+ def process(self, element) -> Iterator[object]:
+ time.sleep(0.001)
+ yield element
+
+ def finish_bundle(self):
+ yield window.GlobalWindows.windowed_value('endOfBundle')
+
+ with self.create_pipeline() as p:
+ p._options.view_as(DirectOptions).test_splits = {
+ 'SplitMarker': {
+ 'timings': [0, .05], 'fractions': [0.5, 0.5]
+ }
+ }
+ assert_that(
+ p
+ | beam.Create(elements)
+ | 'SplitMarker' >> beam.ParDo(BundleCountingDoFn()),
+ equal_to(elements + ['endOfBundle'] * 2))
Review Comment:
Yeah. Done.
##########
sdks/typescript/src/apache_beam/worker/operators.ts:
##########
@@ -234,6 +257,46 @@ class DataSourceOperator implements IOperator {
throw Error("Data should not come in via process.");
}
+ split(
+ desiredSplit: fnApi.ProcessBundleSplitRequest_DesiredSplit
+ ): fnApi.ProcessBundleSplitResponse_ChannelSplit | undefined {
+ if (!this.started) {
+ return undefined;
+ }
+ const end =
+ this.lastToProcessElement < Infinity
+ ? this.lastToProcessElement
+ : Number(desiredSplit.estimatedInputElements) - 1;
+ console.log(this.lastToProcessElement, this.lastProcessedElement, end);
+ if (this.lastProcessedElement >= end) {
+ return undefined;
+ }
+ var targetLastToProcessElement = Math.floor(
+ this.lastProcessedElement +
+ (end - this.lastProcessedElement) * desiredSplit.fractionOfRemainder
+ );
+ if (desiredSplit.allowedSplitPoints.length) {
+ targetLastToProcessElement =
+ Math.min(
+ ...Array.from(desiredSplit.allowedSplitPoints)
+ .filter((index) => index >= targetLastToProcessElement + 1)
Review Comment:
Renamed and clarified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304467532
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304390846
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304583567
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304202396
# [Codecov](https://codecov.io/gh/apache/beam/pull/23985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23985](https://codecov.io/gh/apache/beam/pull/23985?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bd6975) into [master](https://codecov.io/gh/apache/beam/commit/8617b86fd792ac555233dd79c8ede34c2ce67ecf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8617b86) will **increase** coverage by `0.01%`.
> The diff coverage is `96.77%`.
```diff
@@ Coverage Diff @@
## master #23985 +/- ##
==========================================
+ Coverage 73.45% 73.47% +0.01%
==========================================
Files 709 709
Lines 95973 96009 +36
==========================================
+ Hits 70501 70539 +38
+ Misses 24156 24154 -2
Partials 1316 1316
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.20% <96.77%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/23985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `87.78% <96.29%> (+0.26%)` | :arrow_up: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/23985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `94.91% <100.00%> (+0.01%)` | :arrow_up: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/23985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.48% <100.00%> (+0.03%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/23985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.67% <0.00%> (+0.12%)` | :arrow_up: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/23985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.43% <0.00%> (+0.38%)` | :arrow_up: |
| [...thon/apache\_beam/ml/inference/sklearn\_inference.py](https://codecov.io/gh/apache/beam/pull/23985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvaW5mZXJlbmNlL3NrbGVhcm5faW5mZXJlbmNlLnB5) | `96.29% <0.00%> (+0.52%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1309184729
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304563421
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304569227
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304573815
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1309498284
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304337964
stop reviewer notifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304449919
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304552798
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304437309
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304432237
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304602412
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304393921
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23985: Support dynamic sharding in the worker.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23985:
URL: https://github.com/apache/beam/pull/23985#issuecomment-1304548597
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org