You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/11 10:11:38 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #12608: fix(tooltip): added dispose method for rich tooltip, close #12607.

plainheart opened a new pull request #12608:
URL: https://github.com/apache/incubator-echarts/pull/12608


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Added the  `dispose` method for rich tooltip, closes #12607.
   
   
   ### Fixed issues
   
   - #12607
   
   
   ## Details
   
   ### Before: What was the problem?
   
   An error will occur when calling `chart.dispose()`.
   
   
   ### After: How is it fixed in this PR?
   
   Add the  `dispose` method for `TooltipRichContent`.
   
   ## Usage
   
   ### Related test cases or examples to use the new APIs
   
   Refer to `test/tooltip-rich.html`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12608: fix(tooltip): added dispose method for rich tooltip, close #12607.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12608:
URL: https://github.com/apache/incubator-echarts/pull/12608#issuecomment-626608881


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org