You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/04/28 15:52:24 UTC
[GitHub] flink pull request #3799: [FLINK-6409] [table] TUMBLE/HOP/SESSION_START/END ...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/3799
[FLINK-6409] [table] TUMBLE/HOP/SESSION_START/END do not resolve time field correctly
This is a temporary fix until the next Calcite release 1.13. It adds 5 Calcite files to the Flink code base and modifies one Calcite file in order to successfully run all tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-6409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3799
----
commit 31919bb8be56c55bb601a1e2de74497c2463bdf7
Author: twalthr <tw...@apache.org>
Date: 2017-04-28T15:17:30Z
[FLINK-6409] [table] TUMBLE/HOP/SESSION_START/END do not resolve time field correctly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3799: [FLINK-6409] [table] TUMBLE/HOP/SESSION_START/END do not ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3799
Thanks @twalthr for taking care of this!
Most of the files have been copied from the Calcite master, so I won't review those. The other changes look good.
+1 to merge this PR.
@twalthr, can you also create a JIRA to remove the files when Calcite 1.13 is released?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3799: [FLINK-6409] [table] TUMBLE/HOP/SESSION_START/END do not ...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3799
Thanks @fhueske. I will merge this and create a JIRA for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3799: [FLINK-6409] [table] TUMBLE/HOP/SESSION_START/END ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---