[GitHub] [calcite] chunweilei commented on a change in pull request #1655: [CALCITE-3387] Query with GROUP BY and JOIN ... USING wrongly fails with "Column DEPTNO is ambiguous" error

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1655: [CALCITE-3387] Query with GROUP BY and JOIN ... USING wrongly fails with "Column DEPTNO is ambiguous" error
URL: https://github.com/apache/calcite/pull/1655#discussion_r358751132
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
 ##########
 @@ -5389,6 +5435,16 @@ protected void validateFeature(
     assert feature.getProperties().get("FeatureDefinition") != null;
   }
 
+  public SqlNode expandSelectExpr(SqlNode expr,
+      SelectScope scope, SqlSelect select) {
+    final Expander expander = new SelectExpander(this, scope, select);
+    SqlNode newExpr = expr.accept(expander);
 
 Review comment:
   Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services