You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/09 06:33:40 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #5420: [INLONG-5419][Manager] Pulsar creates model of queue error
GanfengTan opened a new pull request, #5420:
URL: https://github.com/apache/inlong/pull/5420
Fix selection and creation are inconsistent.
- Fixes #5419
### Motivation
No message
### Modifications
No message
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #5420: [INLONG-5419][Manager][Dashboard] Fix the Pulsar creates model of queue error
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #5420:
URL: https://github.com/apache/inlong/pull/5420#discussion_r941954654
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -152,7 +152,7 @@ public void createTopic(PulsarAdmin pulsarAdmin, PulsarTopicBean topicBean) thro
}
try {
- if (PULSAR_QUEUE_TYPE_SERIAL.equals(topicBean.getQueueModule())) {
+ if (PULSAR_QUEUE_TYPE_SERIAL.equalsIgnoreCase(topicBean.getQueueModule())) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5420: [INLONG-5419][Manager][Dashboard] Fix the Pulsar creates model of queue error
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5420:
URL: https://github.com/apache/inlong/pull/5420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5420: [INLONG-5419][Manager] Pulsar creates model of queue error
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5420:
URL: https://github.com/apache/inlong/pull/5420#discussion_r941069539
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -152,7 +152,7 @@ public void createTopic(PulsarAdmin pulsarAdmin, PulsarTopicBean topicBean) thro
}
try {
- if (PULSAR_QUEUE_TYPE_SERIAL.equals(topicBean.getQueueModule())) {
+ if (PULSAR_QUEUE_TYPE_SERIAL.equalsIgnoreCase(topicBean.getQueueModule())) {
Review Comment:
It is recommended to standardize the parameters passed externally instead of making different types of case compatibility on the server side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org