You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/08/18 09:01:24 UTC
Review Request 37569: FALCON-1403: Revisit IT cleanup and teardown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37569/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Currently in many of the integration tests such as FalconCLIIT, FalconCLISmokeIT, etc.. there is not cleanup happening after the testcase runs; this leads to many entities getting accumulated in memory, which in turn leads to tests failing due to out of memory error
Diffs
-----
webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java c7b7d3b
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java 5faf5b5
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java e328d69
webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java 7c1a42e
webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java ed85db0
webapp/src/test/java/org/apache/falcon/lifecycle/FileSystemFeedReplicationIT.java d7f36da
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 2a14ae4
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedReplicationIT.java 13bc480
webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 575b870
webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 2e882ea
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java c602ffb
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a
webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java fd78b4b
webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java eb1dda8
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 7b227b3
webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 431d334
webapp/src/test/java/org/apache/falcon/validation/FeedEntityValidationIT.java f6d941c
Diff: https://reviews.apache.org/r/37569/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal
Re: Review Request 37569: FALCON-1403: Revisit IT cleanup and teardown
Posted by Narayan Periwal <na...@inmobi.com>.
> On Aug. 19, 2015, 7:11 a.m., Pallavi Rao wrote:
> > webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java, line 137
> > <https://reviews.apache.org/r/37569/diff/1/?file=1042944#file1042944line137>
> >
> > Since you are deleting all entities from store, there won't be a need for deleting them individually, please remove these lines.
Here only, I am deleting all the entities from the store one by one. I have left the cleanupStore() method (where we only remove the entities from the store) untouched, as it is being used up somewhere else
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37569/#review95836
-----------------------------------------------------------
On Aug. 18, 2015, 7:01 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37569/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 7:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently in many of the integration tests such as FalconCLIIT, FalconCLISmokeIT, etc.. there is not cleanup happening after the testcase runs; this leads to many entities getting accumulated in memory, which in turn leads to tests failing due to out of memory error
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java c7b7d3b
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java 5faf5b5
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java e328d69
> webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java 7c1a42e
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java ed85db0
> webapp/src/test/java/org/apache/falcon/lifecycle/FileSystemFeedReplicationIT.java d7f36da
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 2a14ae4
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedReplicationIT.java 13bc480
> webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 575b870
> webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 2e882ea
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java c602ffb
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java fd78b4b
> webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java eb1dda8
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 7b227b3
> webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 431d334
> webapp/src/test/java/org/apache/falcon/validation/FeedEntityValidationIT.java f6d941c
>
> Diff: https://reviews.apache.org/r/37569/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37569: FALCON-1403: Revisit IT cleanup and teardown
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37569/#review95836
-----------------------------------------------------------
webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java (line 137)
<https://reviews.apache.org/r/37569/#comment150990>
Since you are deleting all entities from store, there won't be a need for deleting them individually, please remove these lines.
- Pallavi Rao
On Aug. 18, 2015, 7:01 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37569/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 7:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently in many of the integration tests such as FalconCLIIT, FalconCLISmokeIT, etc.. there is not cleanup happening after the testcase runs; this leads to many entities getting accumulated in memory, which in turn leads to tests failing due to out of memory error
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java c7b7d3b
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java 5faf5b5
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java e328d69
> webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java 7c1a42e
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java ed85db0
> webapp/src/test/java/org/apache/falcon/lifecycle/FileSystemFeedReplicationIT.java d7f36da
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 2a14ae4
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedReplicationIT.java 13bc480
> webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 575b870
> webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 2e882ea
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java c602ffb
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java fd78b4b
> webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java eb1dda8
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 7b227b3
> webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 431d334
> webapp/src/test/java/org/apache/falcon/validation/FeedEntityValidationIT.java f6d941c
>
> Diff: https://reviews.apache.org/r/37569/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37569: FALCON-1403: Revisit IT cleanup and teardown
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37569/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 7:13 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Currently in many of the integration tests such as FalconCLIIT, FalconCLISmokeIT, etc.. there is not cleanup happening after the testcase runs; this leads to many entities getting accumulated in memory, which in turn leads to tests failing due to out of memory error
Diffs (updated)
-----
webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java c7b7d3b
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java 5faf5b5
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b859256
webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java 7c1a42e
webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java ed85db0
webapp/src/test/java/org/apache/falcon/lifecycle/FileSystemFeedReplicationIT.java d7f36da
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 2a14ae4
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedReplicationIT.java 13bc480
webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 575b870
webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 2e882ea
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 220e5a7
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a
webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java fd78b4b
webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 8594603
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java d13caae
webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137
webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java cc6615b
webapp/src/test/java/org/apache/falcon/validation/FeedEntityValidationIT.java f6d941c
Diff: https://reviews.apache.org/r/37569/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal
Re: Review Request 37569: FALCON-1403: Revisit IT cleanup and teardown
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37569/
-----------------------------------------------------------
(Updated Aug. 19, 2015, 10:01 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Currently in many of the integration tests such as FalconCLIIT, FalconCLISmokeIT, etc.. there is not cleanup happening after the testcase runs; this leads to many entities getting accumulated in memory, which in turn leads to tests failing due to out of memory error
Diffs (updated)
-----
webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java c7b7d3b
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java 5faf5b5
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java e328d69
webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java 7c1a42e
webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java ed85db0
webapp/src/test/java/org/apache/falcon/lifecycle/FileSystemFeedReplicationIT.java d7f36da
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 2a14ae4
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedReplicationIT.java 13bc480
webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 575b870
webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 2e882ea
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java c602ffb
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a
webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java fd78b4b
webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java eb1dda8
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 7b227b3
webapp/src/test/java/org/apache/falcon/validation/ClusterEntityValidationIT.java 431d334
webapp/src/test/java/org/apache/falcon/validation/FeedEntityValidationIT.java f6d941c
Diff: https://reviews.apache.org/r/37569/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal