[GitHub] [spark] Peng-Lei commented on a change in pull request #35268: [SPARK-37950][SQL] Take EXTERNAL as a reserved table property

[GitBox <gi...@apache.org>]

Peng-Lei commented on a change in pull request #35268:
URL: https://github.com/apache/spark/pull/35268#discussion_r789494664



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -843,11 +843,10 @@ class HiveDDLSuite
       // The table type is not changed to external
       assert(
         catalog.getTableMetadata(TableIdentifier(tabName)).tableType == CatalogTableType.MANAGED)
-      // The table property is case sensitive. Thus, external is allowed
-      sql(s"ALTER TABLE $tabName SET TBLPROPERTIES ('external' = 'TRUE')")
-      // The table type is not changed to external
-      assert(
-        catalog.getTableMetadata(TableIdentifier(tabName)).tableType == CatalogTableType.MANAGED)
+      val e1 = intercept[ParseException] {
+        sql(s"ALTER TABLE $tabName SET TBLPROPERTIES ('external'='bar')")

Review comment:
       yeah. 'External'='bar' still works. `EXTERNAL` is the key word of the hive metastore. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org